From: "Pali Rohár" <pali@kernel.org>
To: Ingmar Klein <ingmar_klein@web.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: QCA6174 pcie wifi: Add pci quirks
Date: Wed, 8 Sep 2021 22:35:59 +0200 [thread overview]
Message-ID: <20210908203559.6k5clg3fzf5kctbw@pali> (raw)
In-Reply-To: <408e5b45-3eaa-fa13-318d-48f7d1ecdacf@web.de>
On Wednesday 08 September 2021 21:18:00 Ingmar Klein wrote:
> Am 21.08.2021 um 01:22 schrieb Pali Rohár:
> > On Wednesday 21 July 2021 10:54:53 Pali Rohár wrote:
> > > On Tuesday 25 May 2021 17:12:15 Bjorn Helgaas wrote:
> > > > On Thu, Apr 15, 2021 at 09:53:38PM +0200, Pali Rohár wrote:
> > > > > Hello!
> > > > >
> > > > > On Thursday 15 April 2021 13:01:19 Alex Williamson wrote:
> > > > > > [cc +Pali]
> > > > > >
> > > > > > On Thu, 15 Apr 2021 20:02:23 +0200
> > > > > > Ingmar Klein <ingmar_klein@web.de> wrote:
> > > > > >
> > > > > > > First thanks to you both, Alex and Bjorn!
> > > > > > > I am in no way an expert on this topic, so I have to fully rely on your
> > > > > > > feedback, concerning this issue.
> > > > > > >
> > > > > > > If you should have any other solution approach, in form of patch-set, I
> > > > > > > would be glad to test it out. Just let me know, what you think might
> > > > > > > make sense.
> > > > > > > I will wait for your further feedback on the issue. In the meantime I
> > > > > > > have my current workaround via quirk entry.
> > > > > > >
> > > > > > > By the way, my layman's question:
> > > > > > > Do you think, that the following topic might also apply for the QCA6174?
> > > > > > > https://www.spinics.net/lists/linux-pci/msg106395.html
> > > > > I have been testing more ath cards and I'm going to send a new version
> > > > > of this patch with including more PCI ids.
> > > > Dropping this patch in favor of Pali's new version.
> > > Hello Bjorn! Seems that it would take much more time to finish my
> > > version of patch. So could you take Ingmar's patch with cc:stable tag
> > > for now, which just adds PCI device id into list of problematic devices?
> > Ping, gentle reminder...
>
> Hi Pali and Bjorn,
>
> here is the original trivial patch again.
> For the moment, this could do.
>
> Thank you!
> Best regards,
> Ingmar
>
> Signed-off-by: Ingmar Klein <ingmar_klein@web.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
Cc: stable@vger.kernel.org
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 706f27a86a8e..ecfe80ec5b9c 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3584,6 +3584,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0032, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x003c, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0033, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0034, quirk_no_bus_reset);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x003e, quirk_no_bus_reset);
>
> /*
> * Root port on some Cavium CN8xxx chips do not successfully complete a bus
next prev parent reply other threads:[~2021-09-08 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d74205a4-8a69-c383-e265-1ed5b8508422@web.de>
2021-04-09 9:26 ` QCA6174 pcie wifi: Add pci quirks Ingmar Klein
2021-04-14 21:03 ` Bjorn Helgaas
2021-04-15 2:36 ` Alex Williamson
2021-04-15 18:02 ` Ingmar Klein
2021-04-15 19:01 ` Alex Williamson
2021-04-15 19:53 ` Pali Rohár
2021-05-25 22:12 ` Bjorn Helgaas
2021-05-28 18:08 ` Ingmar Klein
2021-05-28 18:21 ` Pali Rohár
2021-05-28 18:47 ` Ingmar Klein
2021-06-05 14:46 ` Ingmar Klein
2021-06-08 18:34 ` Pali Rohár
2021-06-09 17:07 ` Ingmar Klein
2021-07-21 8:54 ` Pali Rohár
2021-08-20 23:22 ` Pali Rohár
2021-09-08 19:18 ` Ingmar Klein
2021-09-08 20:35 ` Pali Rohár [this message]
2021-09-14 21:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908203559.6k5clg3fzf5kctbw@pali \
--to=pali@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=ingmar_klein@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).