From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB90C433EF for ; Thu, 9 Sep 2021 12:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C72B66113E for ; Thu, 9 Sep 2021 12:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345090AbhIIMHj (ORCPT ); Thu, 9 Sep 2021 08:07:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344551AbhIIMCU (ORCPT ); Thu, 9 Sep 2021 08:02:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ABA746142A; Thu, 9 Sep 2021 11:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631187993; bh=p+dPIwG9V9V2zwpdYIFOMjTOYuq6U/cMiuAugfdolhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZkJsnltyG1pvlHvAjcb3yuSIydpRBt3jGiVBb7EqTHomoDd5ecY3pvbApBqknM+tj KCfh7j4qPqav0wrtvLimJ8/q8Pmfc0Zy/n+Z1ymQDpKQ0RaEjTPP7nqe7EAR9PhUmn WN1PrufqpsYSCTxgDc69jhx7MXkwgQtk3mIYyTMn9L6Kq6apiye77VjAM4MVN4BbaX b5S7dq+dTxWnG/HG5YjPmH3CRR3rJSwzaJsk9VJkdMZhc+kkmWGvA2um80eRaiN4Ev 7P3H9nl4qGUNH5CLJxGwwgOTuIHXdr3jhtFfT/EXzBEiWbDQLBFeELgHO8lmtSobUi hYK3KRgIUEH7w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guojia Liao , Guangbin Huang , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 252/252] net: hns3: clean up a type mismatch warning Date: Thu, 9 Sep 2021 07:41:06 -0400 Message-Id: <20210909114106.141462-252-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909114106.141462-1-sashal@kernel.org> References: <20210909114106.141462-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guojia Liao [ Upstream commit e79c0e324b011b0288cd411a5b53870a7730f163 ] abs() returns signed long, which could not convert the type as unsigned, and it may cause a mismatch type warning from static tools. To fix it, this patch uses an variable to save the abs()'s result and does a explicit conversion. Signed-off-by: Guojia Liao Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c index c0a478ae9583..0dbed35645ed 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c @@ -10,7 +10,14 @@ static u16 hclge_errno_to_resp(int errno) { - return abs(errno); + int resp = abs(errno); + + /* The status for pf to vf msg cmd is u16, constrainted by HW. + * We need to keep the same type with it. + * The intput errno is the stander error code, it's safely to + * use a u16 to store the abs(errno). + */ + return (u16)resp; } /* hclge_gen_resp_to_vf: used to generate a synchronous response to VF when PF -- 2.30.2