* [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000
@ 2021-09-09 10:58 Konstantin Komarov
2021-09-09 12:30 ` Kari Argillander
0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Komarov @ 2021-09-09 10:58 UTC (permalink / raw)
To: ntfs3; +Cc: linux-kernel, linux-fsdevel
xfstest 041 works with 3003, so we need to
raise limit.
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
---
fs/ntfs3/ntfs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
index 6bb3e595263b..0006481db7fa 100644
--- a/fs/ntfs3/ntfs.h
+++ b/fs/ntfs3/ntfs.h
@@ -21,7 +21,8 @@
#define NTFS_NAME_LEN 255
/* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
-#define NTFS_LINK_MAX 0x400
+/* xfstest 041 creates 3003 hardlinks. */
+#define NTFS_LINK_MAX 4000
//#define NTFS_LINK_MAX 0xffff
/*
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000
2021-09-09 10:58 [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
@ 2021-09-09 12:30 ` Kari Argillander
2021-09-09 12:57 ` Kari Argillander
0 siblings, 1 reply; 4+ messages in thread
From: Kari Argillander @ 2021-09-09 12:30 UTC (permalink / raw)
To: Konstantin Komarov; +Cc: ntfs3, linux-kernel, linux-fsdevel
On Thu, Sep 09, 2021 at 01:58:04PM +0300, Konstantin Komarov wrote:
> xfstest 041 works with 3003, so we need to
> raise limit.
No need to linebreak.
>
> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> ---
> fs/ntfs3/ntfs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
> index 6bb3e595263b..0006481db7fa 100644
> --- a/fs/ntfs3/ntfs.h
> +++ b/fs/ntfs3/ntfs.h
> @@ -21,7 +21,8 @@
> #define NTFS_NAME_LEN 255
>
> /* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
> -#define NTFS_LINK_MAX 0x400
> +/* xfstest 041 creates 3003 hardlinks. */
It think comment is unnecessary here. If you think this is necassarry
comment then please but it same comment block as last row.
> +#define NTFS_LINK_MAX 4000
What draw backs there is if this is 4000? We really do not care about
xfstests if we have some reason to not do this. This info can be but
to commit message.
> //#define NTFS_LINK_MAX 0xffff
We can probably same time get rid of this.
>
> /*
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000
2021-09-09 12:30 ` Kari Argillander
@ 2021-09-09 12:57 ` Kari Argillander
0 siblings, 0 replies; 4+ messages in thread
From: Kari Argillander @ 2021-09-09 12:57 UTC (permalink / raw)
To: Konstantin Komarov; +Cc: ntfs3, linux-kernel, linux-fsdevel
On Thu, Sep 09, 2021 at 03:30:34PM +0300, Kari Argillander wrote:
> On Thu, Sep 09, 2021 at 01:58:04PM +0300, Konstantin Komarov wrote:
> > xfstest 041 works with 3003, so we need to
And it would be good to write generic/041. This way grepping is little
easier.
> > raise limit.
>
> No need to linebreak.
>
> >
> > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> > ---
> > fs/ntfs3/ntfs.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
> > index 6bb3e595263b..0006481db7fa 100644
> > --- a/fs/ntfs3/ntfs.h
> > +++ b/fs/ntfs3/ntfs.h
> > @@ -21,7 +21,8 @@
> > #define NTFS_NAME_LEN 255
> >
> > /* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
> > -#define NTFS_LINK_MAX 0x400
> > +/* xfstest 041 creates 3003 hardlinks. */
>
> It think comment is unnecessary here. If you think this is necassarry
> comment then please but it same comment block as last row.
>
> > +#define NTFS_LINK_MAX 4000
>
> What draw backs there is if this is 4000? We really do not care about
> xfstests if we have some reason to not do this. This info can be but
> to commit message.
>
> > //#define NTFS_LINK_MAX 0xffff
>
> We can probably same time get rid of this.
>
> >
> > /*
> > --
> > 2.28.0
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/3] fs/ntfs3: Speed up hardlink creation
@ 2021-09-13 15:09 Konstantin Komarov
2021-09-13 15:14 ` [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Komarov @ 2021-09-13 15:09 UTC (permalink / raw)
To: ntfs3; +Cc: linux-kernel, linux-fsdevel
xfstest generic/041 was taking some time before failing,
so this series aims to fix it and speed up.
Because of this we raise hardlinks limit to 4000.
There are no drawbacks or regressions.
Theoretically we can raise all the way up to ffff,
but there is no practical use for this.
Konstantin Komarov (3):
fs/ntfs3: Fix insertion of attr in ni_ins_attr_ext
fs/ntfs3: Change max hardlinks limit to 4000
fs/ntfs3: Add sync flag to ntfs_sb_write_run and al_update
fs/ntfs3/attrib.c | 2 +-
fs/ntfs3/attrlist.c | 6 +++---
fs/ntfs3/frecord.c | 9 ++++++++-
fs/ntfs3/fslog.c | 8 ++++----
fs/ntfs3/fsntfs.c | 8 ++++----
fs/ntfs3/inode.c | 2 +-
fs/ntfs3/ntfs.h | 8 +++++---
fs/ntfs3/ntfs_fs.h | 4 ++--
fs/ntfs3/xattr.c | 2 +-
9 files changed, 29 insertions(+), 20 deletions(-)
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000
2021-09-13 15:09 [PATCH 0/3] fs/ntfs3: Speed up hardlink creation Konstantin Komarov
@ 2021-09-13 15:14 ` Konstantin Komarov
0 siblings, 0 replies; 4+ messages in thread
From: Konstantin Komarov @ 2021-09-13 15:14 UTC (permalink / raw)
To: ntfs3; +Cc: linux-kernel, linux-fsdevel
xfstest generic/041 works with 3003, so we need to raise limit.
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
---
fs/ntfs3/ntfs.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
index 6bb3e595263b..6c604204d77b 100644
--- a/fs/ntfs3/ntfs.h
+++ b/fs/ntfs3/ntfs.h
@@ -20,9 +20,11 @@
#define NTFS_NAME_LEN 255
-/* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
-#define NTFS_LINK_MAX 0x400
-//#define NTFS_LINK_MAX 0xffff
+/*
+ * ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff.
+ * xfstest generic/041 creates 3003 hardlinks.
+ */
+#define NTFS_LINK_MAX 4000
/*
* Activate to use 64 bit clusters instead of 32 bits in ntfs.sys.
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-13 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 10:58 [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
2021-09-09 12:30 ` Kari Argillander
2021-09-09 12:57 ` Kari Argillander
2021-09-13 15:09 [PATCH 0/3] fs/ntfs3: Speed up hardlink creation Konstantin Komarov
2021-09-13 15:14 ` [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).