[PATCH] ARM: scoop: move EXPORT_SYMBOLs to follow their funcs

[PATCH] ARM: scoop: move EXPORT_SYMBOLs to follow their funcs

[Jason Wang]

Usually, EXPORT_SYMBOLs should immediately follow their functions or
variables.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 arch/arm/common/scoop.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c
index 6edb961bd6c1..746919c18bb1 100644
--- a/arch/arm/common/scoop.c
+++ b/arch/arm/common/scoop.c
@@ -49,6 +49,7 @@ void reset_scoop(struct device *dev)
 	iowrite16(0x0000, sdev->base + SCOOP_ISR);  /* 1C */
 	iowrite16(0x0000, sdev->base + SCOOP_IRM);
 }
+EXPORT_SYMBOL(reset_scoop);
 
 static void __scoop_gpio_set(struct scoop_dev *sdev,
 			unsigned offset, int value)
@@ -126,15 +127,13 @@ unsigned short read_scoop_reg(struct device *dev, unsigned short reg)
 	struct scoop_dev *sdev = dev_get_drvdata(dev);
 	return ioread16(sdev->base + reg);
 }
+EXPORT_SYMBOL(read_scoop_reg);
 
 void write_scoop_reg(struct device *dev, unsigned short reg, unsigned short data)
 {
 	struct scoop_dev *sdev = dev_get_drvdata(dev);
 	iowrite16(data, sdev->base + reg);
 }
-
-EXPORT_SYMBOL(reset_scoop);
-EXPORT_SYMBOL(read_scoop_reg);
 EXPORT_SYMBOL(write_scoop_reg);
 
 #ifdef CONFIG_PM
-- 
2.32.0

Re: [PATCH] ARM: scoop: move EXPORT_SYMBOLs to follow their funcs

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

Hello,

On Tue, Jul 27, 2021 at 09:05:47PM +0800, Jason Wang wrote:
> Usually, EXPORT_SYMBOLs should immediately follow their functions or
> variables.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Unless rmk objects I think you can send this to his patch tracker.
(https://www.arm.linux.org.uk/developer/patches/info.php)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]