From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC75C433EF for ; Thu, 9 Sep 2021 18:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 423E9610E9 for ; Thu, 9 Sep 2021 18:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244146AbhIISL1 (ORCPT ); Thu, 9 Sep 2021 14:11:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243493AbhIISLK (ORCPT ); Thu, 9 Sep 2021 14:11:10 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7888C061756 for ; Thu, 9 Sep 2021 11:10:00 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id r3so4359126ljc.4 for ; Thu, 09 Sep 2021 11:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xyyx98ohvBGLtu/RXBFKIsLv16m8Wp4VyNHMtY264u0=; b=VzYjqIkohug8LcjSPPZbKDhi+RnOICZQIhj5CQdOX0jebUnadgBAvGoOsliXZ6/swK LquJdWA/OJWavR/uAeFfuJ4FVHmmV82X7i9EssOEVeA39xGw94dmYlkD/nvXZv0ahHFU JHl8TX/O+e/Rkb2GGen7mLyy0Il42Sl09fsgL4Uq1M2uAYI0KNHexZzixSAZSsHFyu4y 3yqeUgOxofqcnfGa+92r4sIUTIevbTs9+jHaucbyvwLVPbnw/IK1shfSwNMmL0WFCU+X IeFf6zK3gcHbBJliSNkZpXTrqo/dXQHVRNk6vBpH7XcbAUXcOXku0EhmIL5PdBqlN0Zt KZWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xyyx98ohvBGLtu/RXBFKIsLv16m8Wp4VyNHMtY264u0=; b=urO8Kta/YZeS4l9sGHPCnl+26R2MpDRcflhcMyg9aNcd+CFIBfCjgtajv7Nt7to0uZ 1H6vSnHYkeD8IOmrjjDP831r+AKIi1+If9KKN/e+8URUWHCqPL+VRVwJWv8GYLM5ygIu nGLkI4LQhUYFliup3MFkp7EN16TzE3wTMGdmoprdii5qsybz4K1LLA7apu/EMsiyR9tg WHc42y4EbM7rqBCQpQx3EGxK2ngC6z29PeQ0M7WzyIXnNNIlxbxAJWqLdNjqbhwJMwZ7 a7sYwgI9K/Pyb4hUWn0c2k+lFESbvkMH2D6knPJRIBkxHbOt8VGydC91L9NngZgkHSth Lv4Q== X-Gm-Message-State: AOAM533w1UI6h4QHEyDu5WUo5+GbkquNcqmOZCVZwAWEm63UdrwhTH3D ss2LtaUSpTQa+g52oWUXQO8= X-Google-Smtp-Source: ABdhPJyrS8ytRV+reeTGCs9+kg8U+/JVQ78r1mc/Dny6y+bu4yOKYC1AaVHhu/K0FRLqs2peASq3Sg== X-Received: by 2002:a2e:9607:: with SMTP id v7mr863208ljh.405.1631210999293; Thu, 09 Sep 2021 11:09:59 -0700 (PDT) Received: from kari-VirtualBox.telewell.oy (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id u2sm270276lff.238.2021.09.09.11.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 11:09:58 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , linux-kernel@vger.kernel.org, Christian Brauner Subject: [PATCH 05/11] fs/ntfs3: Remove unnecessary variable loading in fill_super Date: Thu, 9 Sep 2021 21:09:36 +0300 Message-Id: <20210909180942.8634-6-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210909180942.8634-1-kari.argillander@gmail.com> References: <20210909180942.8634-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove some unnecessary variable loading. These look like copy paste work and they are not used to anything. Signed-off-by: Kari Argillander --- fs/ntfs3/super.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index f3c3c2bea6ca..2eb1227bbf5a 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -879,7 +879,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) struct block_device *bdev = sb->s_bdev; struct inode *bd_inode = bdev->bd_inode; struct request_queue *rq = bdev_get_queue(bdev); - struct inode *inode = NULL; + struct inode *inode; struct ntfs_inode *ni; size_t i, tt; CLST vcn, lcn, len; @@ -979,9 +979,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) sbi->volume.major_ver = info->major_ver; sbi->volume.minor_ver = info->minor_ver; sbi->volume.flags = info->flags; - sbi->volume.ni = ni; - inode = NULL; /* Load $MFTMirr to estimate recs_mirr. */ ref.low = cpu_to_le32(MFT_REC_MIRR); @@ -1013,7 +1011,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) goto out; iput(inode); - inode = NULL; is_ro = sb_rdonly(sbi->sb); @@ -1090,8 +1087,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) return PTR_ERR(inode); } - ni = ntfs_i(inode); - #ifndef CONFIG_NTFS3_64BIT_CLUSTER if (inode->i_size >> 32) { err = -EINVAL; @@ -1190,8 +1185,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) return PTR_ERR(inode); } - ni = ntfs_i(inode); - if (inode->i_size != 0x10000 * sizeof(short)) { err = -EINVAL; goto out; @@ -1227,7 +1220,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) } iput(inode); - inode = NULL; if (is_ntfs3(sbi)) { /* Load $Secure. */ @@ -1261,8 +1253,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) return PTR_ERR(inode); } - ni = ntfs_i(inode); - sb->s_root = d_make_root(inode); if (!sb->s_root) return -ENOMEM; -- 2.25.1