From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41149C433F5 for ; Fri, 10 Sep 2021 00:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2627A60F6B for ; Fri, 10 Sep 2021 00:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240216AbhIJAuu (ORCPT ); Thu, 9 Sep 2021 20:50:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:46316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233520AbhIJAUS (ORCPT ); Thu, 9 Sep 2021 20:20:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 363F261167; Fri, 10 Sep 2021 00:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233135; bh=nooKu3Gi3ZWSe/TIfy3fI8i8GyXZlCmt/7fj2bnbOxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DSvEV5Z5ds0OiSxRjAh3FGm7UZL54YlUUgfi4mv9GGzPyW6FLbEwZeD2X8H0WBifE saZrDVY9/NCnLurT8Tuu7pGkW//j6CPB95m6Em7pmkuYgTmanC1PiMCtQ10UiMfpva M+WFe3h6o3Ru05LCdYOdzQ3uZxnrITPXzoS82Nbujv9w/CzyCW9paQKfNEuMXzOEUy 2lbr8KC3E2C4PTkG8Lmkqn8eKl5GlLTGFBXHqwHVoPI3lyAFev407ItrxhqVo2pR4K ytrr4MlQgQ7FrIgCtFVnamgOrVFnOnPhaOiKFwHOOXo/RTF/1+aLXgR3ExKJ2wa3pl pfJVzps9cIW0g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Laibin Qiu , Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.13 24/88] f2fs: fix min_seq_blocks can not make sense in some scenes. Date: Thu, 9 Sep 2021 20:17:16 -0400 Message-Id: <20210910001820.174272-24-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laibin Qiu [ Upstream commit dc675a97129c4d9d5af55a3d7f23d7e092b8e032 ] F2FS have dirty page count control for batched sequential write in writepages, and get the value of min_seq_blocks by blocks_per_seg * segs_per_sec(segs_per_sec defaults to 1). But in some scenes we set a lager section size, Min_seq_blocks will become too large to achieve the expected effect(eg. 4thread sequential write, the number of merge requests will be reduced). Signed-off-by: Laibin Qiu Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 51dc79fad4fe..800656e082c5 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -5147,7 +5147,7 @@ int f2fs_build_segment_manager(struct f2fs_sb_info *sbi) sm_info->ipu_policy = 1 << F2FS_IPU_FSYNC; sm_info->min_ipu_util = DEF_MIN_IPU_UTIL; sm_info->min_fsync_blocks = DEF_MIN_FSYNC_BLOCKS; - sm_info->min_seq_blocks = sbi->blocks_per_seg * sbi->segs_per_sec; + sm_info->min_seq_blocks = sbi->blocks_per_seg; sm_info->min_hot_blocks = DEF_MIN_HOT_BLOCKS; sm_info->min_ssr_sections = reserved_sections(sbi); -- 2.30.2