linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>, yangerkun <yangerkun@huawei.com>,
	Sasha Levin <sashal@kernel.org>,
	linux-ext4@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 20/25] ext4: if zeroout fails fall back to splitting the extent node
Date: Thu,  9 Sep 2021 20:22:28 -0400	[thread overview]
Message-ID: <20210910002234.176125-20-sashal@kernel.org> (raw)
In-Reply-To: <20210910002234.176125-1-sashal@kernel.org>

From: Theodore Ts'o <tytso@mit.edu>

[ Upstream commit 308c57ccf4318236be75dfa251c84713e694457b ]

If the underlying storage device is using thin-provisioning, it's
possible for a zeroout operation to return ENOSPC.

Commit df22291ff0fd ("ext4: Retry block allocation if we have free blocks
left") added logic to retry block allocation since we might get free block
after we commit a transaction. But the ENOSPC from thin-provisioning
will confuse ext4, and lead to an infinite loop.

Since using zeroout instead of splitting the extent node is an
optimization, if it fails, we might as well fall back to splitting the
extent node.

Reported-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/ext4/extents.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 2a45e0d3e593..d46f305b5fbd 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3625,7 +3625,7 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
 				split_map.m_len - ee_block);
 			err = ext4_ext_zeroout(inode, &zero_ex1);
 			if (err)
-				goto out;
+				goto fallback;
 			split_map.m_len = allocated;
 		}
 		if (split_map.m_lblk - ee_block + split_map.m_len <
@@ -3639,7 +3639,7 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
 						      ext4_ext_pblock(ex));
 				err = ext4_ext_zeroout(inode, &zero_ex2);
 				if (err)
-					goto out;
+					goto fallback;
 			}
 
 			split_map.m_len += split_map.m_lblk - ee_block;
@@ -3648,6 +3648,7 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
 		}
 	}
 
+fallback:
 	err = ext4_split_extent(handle, inode, ppath, &split_map, split_flag,
 				flags);
 	if (err > 0)
-- 
2.30.2


  parent reply	other threads:[~2021-09-10  1:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  0:22 [PATCH AUTOSEL 4.19 01/25] clk: rockchip: rk3036: fix up the sclk_sfc parent error Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 02/25] scsi: smartpqi: Fix ISR accessing uninitialized data Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 03/25] scsi: lpfc: Fix cq_id truncation in rq create Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 04/25] clk: mediatek: Fix asymmetrical PLL enable and disable control Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 05/25] HID: usbhid: free raw_report buffers in usbhid_stop Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 06/25] f2fs: fix to force keeping write barrier for strict fsync mode Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 07/25] f2fs: fix min_seq_blocks can not make sense in some scenes Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 08/25] powerpc: make the install target not depend on any build artifact Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 09/25] jbd2: fix portability problems caused by unaligned accesses Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 10/25] scsi: qla2xxx: Fix NPIV create erroneous error Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 11/25] scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd() Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 12/25] fs: dlm: fix return -EINTR on recovery stopped Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 13/25] scsi: core: Fix missing FORCE for scsi_devinfo_tbl.c build rule Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 14/25] powerpc/32: indirect function call use bctrl rather than blrl in ret_from_kernel_thread Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 15/25] powerpc/booke: Avoid link stack corruption in several places Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 16/25] KVM: PPC: Book3S HV: Initialise vcpu MSR with MSR_ME Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 17/25] KVM: PPC: Book3S HV P9: Fixes for TM softpatch interrupt NIP Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 18/25] RDMA/core/sa_query: Retry SA queries Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 19/25] platform/x86: dell-smbios-wmi: Avoid false-positive memcpy() warning Sasha Levin
2021-09-10  0:22 ` Sasha Levin [this message]
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 21/25] ext4: Make sure quota files are not grabbed accidentally Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 22/25] xen: remove stray preempt_disable() from PV AP startup code Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 23/25] checkkconfigsymbols.py: Fix the '--ignore' option Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 24/25] ocfs2: quota_local: fix possible uninitialized-variable access in ocfs2_local_read_info() Sasha Levin
2021-09-10  0:22 ` [PATCH AUTOSEL 4.19 25/25] ocfs2: ocfs2_downconvert_lock failure results in deadlock Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910002234.176125-20-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yangerkun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).