From: Kari Argillander <kari.argillander@gmail.com>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 31/31] staging: wfx: indent functions arguments
Date: Fri, 10 Sep 2021 19:57:43 +0300 [thread overview]
Message-ID: <20210910165743.jm7ssqak7gouyl5j@kari-VirtualBox> (raw)
In-Reply-To: <20210910160504.1794332-32-Jerome.Pouiller@silabs.com>
On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Function arguments must be aligned with left parenthesis. Apply that
> rule.
To my eyes something still go wrong with this patch. Might be my email
fault, but every other patch looks ok. Now these are too left. Also it
should alight with first argument not left parenthesis?
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
> drivers/staging/wfx/hif_tx_mib.c | 2 +-
> drivers/staging/wfx/key.c | 26 +++++++++++++-------------
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c
> index 45e531d996bd..97e961e6bcf6 100644
> --- a/drivers/staging/wfx/hif_tx_mib.c
> +++ b/drivers/staging/wfx/hif_tx_mib.c
> @@ -75,7 +75,7 @@ int hif_get_counters_table(struct wfx_dev *wdev, int vif_id,
> } else {
> return hif_read_mib(wdev, vif_id,
> HIF_MIB_ID_EXTENDED_COUNTERS_TABLE, arg,
> - sizeof(struct hif_mib_extended_count_table));
> + sizeof(struct hif_mib_extended_count_table));
> }
> }
>
> diff --git a/drivers/staging/wfx/key.c b/drivers/staging/wfx/key.c
> index 51a528102016..65134a174683 100644
> --- a/drivers/staging/wfx/key.c
> +++ b/drivers/staging/wfx/key.c
> @@ -31,7 +31,7 @@ static void wfx_free_key(struct wfx_dev *wdev, int idx)
> }
>
> static u8 fill_wep_pair(struct hif_wep_pairwise_key *msg,
> - struct ieee80211_key_conf *key, u8 *peer_addr)
> + struct ieee80211_key_conf *key, u8 *peer_addr)
> {
> WARN(key->keylen > sizeof(msg->key_data), "inconsistent data");
> msg->key_length = key->keylen;
> @@ -41,7 +41,7 @@ static u8 fill_wep_pair(struct hif_wep_pairwise_key *msg,
> }
>
> static u8 fill_wep_group(struct hif_wep_group_key *msg,
> - struct ieee80211_key_conf *key)
> + struct ieee80211_key_conf *key)
> {
> WARN(key->keylen > sizeof(msg->key_data), "inconsistent data");
> msg->key_id = key->keyidx;
> @@ -51,7 +51,7 @@ static u8 fill_wep_group(struct hif_wep_group_key *msg,
> }
>
> static u8 fill_tkip_pair(struct hif_tkip_pairwise_key *msg,
> - struct ieee80211_key_conf *key, u8 *peer_addr)
> + struct ieee80211_key_conf *key, u8 *peer_addr)
> {
> u8 *keybuf = key->key;
>
> @@ -68,9 +68,9 @@ static u8 fill_tkip_pair(struct hif_tkip_pairwise_key *msg,
> }
>
> static u8 fill_tkip_group(struct hif_tkip_group_key *msg,
> - struct ieee80211_key_conf *key,
> - struct ieee80211_key_seq *seq,
> - enum nl80211_iftype iftype)
> + struct ieee80211_key_conf *key,
> + struct ieee80211_key_seq *seq,
> + enum nl80211_iftype iftype)
> {
> u8 *keybuf = key->key;
>
> @@ -93,7 +93,7 @@ static u8 fill_tkip_group(struct hif_tkip_group_key *msg,
> }
>
> static u8 fill_ccmp_pair(struct hif_aes_pairwise_key *msg,
> - struct ieee80211_key_conf *key, u8 *peer_addr)
> + struct ieee80211_key_conf *key, u8 *peer_addr)
> {
> WARN(key->keylen != sizeof(msg->aes_key_data), "inconsistent data");
> ether_addr_copy(msg->peer_address, peer_addr);
> @@ -102,8 +102,8 @@ static u8 fill_ccmp_pair(struct hif_aes_pairwise_key *msg,
> }
>
> static u8 fill_ccmp_group(struct hif_aes_group_key *msg,
> - struct ieee80211_key_conf *key,
> - struct ieee80211_key_seq *seq)
> + struct ieee80211_key_conf *key,
> + struct ieee80211_key_seq *seq)
> {
> WARN(key->keylen != sizeof(msg->aes_key_data), "inconsistent data");
> memcpy(msg->aes_key_data, key->key, key->keylen);
> @@ -114,7 +114,7 @@ static u8 fill_ccmp_group(struct hif_aes_group_key *msg,
> }
>
> static u8 fill_sms4_pair(struct hif_wapi_pairwise_key *msg,
> - struct ieee80211_key_conf *key, u8 *peer_addr)
> + struct ieee80211_key_conf *key, u8 *peer_addr)
> {
> u8 *keybuf = key->key;
>
> @@ -129,7 +129,7 @@ static u8 fill_sms4_pair(struct hif_wapi_pairwise_key *msg,
> }
>
> static u8 fill_sms4_group(struct hif_wapi_group_key *msg,
> - struct ieee80211_key_conf *key)
> + struct ieee80211_key_conf *key)
> {
> u8 *keybuf = key->key;
>
> @@ -143,8 +143,8 @@ static u8 fill_sms4_group(struct hif_wapi_group_key *msg,
> }
>
> static u8 fill_aes_cmac_group(struct hif_igtk_group_key *msg,
> - struct ieee80211_key_conf *key,
> - struct ieee80211_key_seq *seq)
> + struct ieee80211_key_conf *key,
> + struct ieee80211_key_seq *seq)
> {
> WARN(key->keylen != sizeof(msg->igtk_key_data), "inconsistent data");
> memcpy(msg->igtk_key_data, key->key, key->keylen);
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-09-10 16:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:04 [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance Jerome Pouiller
2021-09-10 16:04 ` [PATCH 01/31] staging: wfx: use abbreviated message for "incorrect sequence" Jerome Pouiller
2021-09-10 16:04 ` [PATCH 02/31] staging: wfx: do not send CAB while scanning Jerome Pouiller
2021-09-10 16:31 ` Kari Argillander
2021-09-10 16:54 ` Jérôme Pouiller
2021-09-10 17:01 ` Kari Argillander
2021-09-10 17:12 ` Jérôme Pouiller
2021-09-10 16:04 ` [PATCH 03/31] staging: wfx: ignore PS when STA/AP share same channel Jerome Pouiller
2021-09-10 16:04 ` [PATCH 04/31] staging: wfx: wait for SCAN_CMPL after a SCAN_STOP Jerome Pouiller
2021-09-10 16:04 ` [PATCH 05/31] staging: wfx: avoid possible lock-up during scan Jerome Pouiller
2021-09-10 16:04 ` [PATCH 06/31] staging: wfx: drop unused argument from hif_scan() Jerome Pouiller
2021-09-10 16:04 ` [PATCH 07/31] staging: wfx: fix atomic accesses in wfx_tx_queue_empty() Jerome Pouiller
2021-09-10 16:04 ` [PATCH 08/31] staging: wfx: take advantage of wfx_tx_queue_empty() Jerome Pouiller
2021-09-10 16:04 ` [PATCH 09/31] staging: wfx: declare support for TDLS Jerome Pouiller
2021-09-10 16:04 ` [PATCH 10/31] staging: wfx: fix support for CSA Jerome Pouiller
2021-09-10 16:04 ` [PATCH 11/31] staging: wfx: relax the PDS existence constraint Jerome Pouiller
2021-09-10 16:04 ` [PATCH 12/31] staging: wfx: simplify API coherency check Jerome Pouiller
2021-09-10 16:04 ` [PATCH 13/31] staging: wfx: update with API 3.8 Jerome Pouiller
2021-09-10 16:43 ` Kari Argillander
2021-09-10 17:03 ` Jérôme Pouiller
2021-09-10 16:04 ` [PATCH 14/31] staging: wfx: uniformize counter names Jerome Pouiller
2021-09-10 16:04 ` [PATCH 15/31] staging: wfx: fix misleading 'rate_id' usage Jerome Pouiller
2021-09-10 16:04 ` [PATCH 16/31] staging: wfx: declare variables at beginning of functions Jerome Pouiller
2021-09-10 16:04 ` [PATCH 17/31] staging: wfx: simplify hif_join() Jerome Pouiller
2021-09-10 16:38 ` Kari Argillander
2021-09-10 16:04 ` [PATCH 18/31] staging: wfx: reorder function for slightly better eye candy Jerome Pouiller
2021-09-10 16:04 ` [PATCH 19/31] staging: wfx: fix error names Jerome Pouiller
2021-09-10 16:04 ` [PATCH 20/31] staging: wfx: apply naming rules in hif_tx_mib.c Jerome Pouiller
2021-09-10 16:04 ` [PATCH 21/31] staging: wfx: remove unused definition Jerome Pouiller
2021-09-10 16:04 ` [PATCH 22/31] staging: wfx: remove useless debug statement Jerome Pouiller
2021-09-10 16:04 ` [PATCH 23/31] staging: wfx: fix space after cast operator Jerome Pouiller
2021-09-10 16:04 ` [PATCH 24/31] staging: wfx: remove references to WFxxx in comments Jerome Pouiller
2021-09-10 16:04 ` [PATCH 25/31] staging: wfx: update files descriptions Jerome Pouiller
2021-09-10 16:04 ` [PATCH 26/31] staging: wfx: reformat comment Jerome Pouiller
2021-09-10 16:05 ` [PATCH 27/31] staging: wfx: avoid c99 comments Jerome Pouiller
2021-09-10 16:05 ` [PATCH 28/31] staging: wfx: fix comments styles Jerome Pouiller
2021-09-10 16:05 ` [PATCH 29/31] staging: wfx: remove useless comments after #endif Jerome Pouiller
2021-09-10 16:27 ` Kari Argillander
2021-09-10 16:49 ` Jérôme Pouiller
2021-09-10 17:05 ` Kari Argillander
2021-09-10 16:05 ` [PATCH 30/31] staging: wfx: explain the purpose of wfx_send_pds() Jerome Pouiller
2021-09-10 16:05 ` [PATCH 31/31] staging: wfx: indent functions arguments Jerome Pouiller
2021-09-10 16:57 ` Kari Argillander [this message]
2021-09-10 17:12 ` Jérôme Pouiller
2021-09-10 17:28 ` Kari Argillander
2021-09-10 17:07 ` [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance Kari Argillander
2021-09-10 17:15 ` Jérôme Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910165743.jm7ssqak7gouyl5j@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).