From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B06CC433EF for ; Fri, 10 Sep 2021 20:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2F2961074 for ; Fri, 10 Sep 2021 20:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234065AbhIJU34 (ORCPT ); Fri, 10 Sep 2021 16:29:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56050 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233384AbhIJU3y (ORCPT ); Fri, 10 Sep 2021 16:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631305723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZfzYDvGGR49FzOLgHKoDc14mu9c9VsKGgvUARxIOsPI=; b=WcrONq6Q86jdGOM3Ta2mbfJrn7X+d7VPHx5XB+Q+It7YdX2/3L26hg6A4ZAVP7SD1nZFn/ 6W8+2CUfzSxw43N6bMSvtEdQEQlYaG4OJ9QcGjIl/JdE6MBD2k0h5Kqjc3EqXOT+XHpkky 2VqrzhFtXRmdYv6QC9OCvG71HP+bzlo= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-nxWnpj4mMwabAZ_Ao9QJGQ-1; Fri, 10 Sep 2021 16:28:41 -0400 X-MC-Unique: nxWnpj4mMwabAZ_Ao9QJGQ-1 Received: by mail-io1-f72.google.com with SMTP id s22-20020a5e98160000b02905afde383110so6597280ioj.8 for ; Fri, 10 Sep 2021 13:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZfzYDvGGR49FzOLgHKoDc14mu9c9VsKGgvUARxIOsPI=; b=deiKJ42G2rGSrdi394C+dL4MqsgWcRss62RMAkWYiv1Wp188DYowSkF3hRqx1xLS4q Xj6qVBBo2ZNRv0+723PYdAe0aUNl1sStRdmwoqNKlqxnZCIcOoxPR5rMVmaKapze/NhV u6sMqHeIhkYW0YqgDdYlb9cZexHW2cREd2byg3eSlMGHzquuiwTuCISOoOtk74cIhnyo fh7yRoFekWXf1T36zHNBeJRWwT5ieary6wEd9nQxT32eYH8H9QVJ3HSm63thn4eiXwQV 6uV0r4XSVNAgh5yYi0P5pD2pauoWiB//dt+yb0vNSJIZseuS4BS7oS4TbkTcEep+mQLd EK3w== X-Gm-Message-State: AOAM530+56UbboC2NVEdJmAjo9pEjqfr6Q2Tn5zx5Em5mERclKGkcRkf kSqURT70ztIKO8cR3/CkAaFPFQng03MSipI/GkmqhbbVDnDw9W3m6sTH8YBx3Hj3d8svF5gZwaU G/o4innqtOZjrgr3mn0T1OtET X-Received: by 2002:a92:c84c:: with SMTP id b12mr4866931ilq.105.1631305721073; Fri, 10 Sep 2021 13:28:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5BvdLGAZYEzKbH9qB02QxBql9QbBnEUluFq99Uk+TecxUcmvkXBLUOASwLE1mzwVyfdI8dQ== X-Received: by 2002:a92:c84c:: with SMTP id b12mr4866922ilq.105.1631305720801; Fri, 10 Sep 2021 13:28:40 -0700 (PDT) Received: from halaneylaptop (068-184-200-203.res.spectrum.com. [68.184.200.203]) by smtp.gmail.com with ESMTPSA id i17sm3018919ioh.21.2021.09.10.13.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 13:28:40 -0700 (PDT) Date: Fri, 10 Sep 2021 15:28:37 -0500 From: Andrew Halaney To: jim.cromie@gmail.com Cc: Jason Baron , LKML Subject: Re: [PATCH] dyndbg: make dyndbg a known cli param Message-ID: <20210910202837.jysyesokwe637rla@halaneylaptop> References: <20210909161755.61743-1-ahalaney@redhat.com> <0849504a-b7ed-f448-6d66-1a9fd5ad70ce@akamai.com> <20210910182445.vao7uhqveaen25tk@halaneylaptop> <20210910201635.4d3fhhrwvcusdwk2@halaneylaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910201635.4d3fhhrwvcusdwk2@halaneylaptop> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2021 at 03:16:35PM -0500, Andrew Halaney wrote: > On Fri, Sep 10, 2021 at 01:31:22PM -0600, jim.cromie@gmail.com wrote: > > On Fri, Sep 10, 2021 at 12:24 PM Andrew Halaney wrote: > > > > > > On Fri, Sep 10, 2021 at 11:14:45AM -0600, jim.cromie@gmail.com wrote: > > > > On Thu, Sep 9, 2021 at 3:34 PM Jason Baron wrote: > > > > > > > > > > > > > > > > > > > On 9/9/21 12:17 PM, Andrew Halaney wrote: > > > > > > Right now dyndbg shows up as an unknown parameter if used on boot: > > > > > > > > > > > > Unknown command line parameters: dyndbg=module params +p ; module > > > > > sys +p > > > > > > > > > > > > That's because it is unknown, it doesn't sit in the __param > > > > > > section, so the processing done to warn users supplying an unknown > > > > > > parameter doesn't think it is legitimate. > > > > > > > > > > > > > > > > > > your usage is incorrect for what youre trying to do in that example > > > > what you need is: > > > > > > > > params.dyndbg=+p sys.dyndbg=+p > > > > > > > > dyndbg is properly unknown as a kernel param, it isnt one. > > > > ( it was called a "fake" module param when added.) > > > > $module.dyndbg is good, since its after the $module. (and the dot) > > > > it also then inherits the "scan bootargs for relevant ones on module load" > > > > behavior > > > > > > > > > > > > > > That example is (slightly altered) from > > > Documentation/admin-guide/dynamic-debug-howto.rst, > > > > oh dear, I see the lines youre referring to. > > I am surprised. > > fyi, those lines are: > > // enable pr_debugs in 2 builtins, #cmt is stripped > > dyndbg="module params +p #cmt ; module sys +p" > > > > is your patchset removing those lines ? > > if so, ack that part. > > > > > I can change the example used to be a little less confusing (using the > > > module keyword is confusing, I could use something like > > > func or file instead of what the docs use as an example). > > > > yes please, I saw bad usage, thought faulty premise. > > > > > Is that what you're after, a better example usage of dyndbg= being > > > whined about in dmesg for the commit message, or am I misunderstanding? > > > > I guess Im inured to it. Heres my regular version with a similar addition. > > > > Unknown command line parameters: > > virtme_link_mods=/home/jimc/projects/lx/wk-next/builds/local-i915m/.virtme_mods/lib/modules/0.0.0 > > virtme_initmount0=/root virtme_initmount1=/root/sbin > > virtme_stty_con=rows 27 cols 109 iutf8 > > virtme_chdir=home/jimc/projects/lx dyndbg=+p > > > > most of them do something, just not for the kernel. > > > > I dont think this is worth explicitly silencing. > > rather rip out the misleading doc. > > > > Ohhhhh, ok now I think I'm following what you and Jason are saying. > > dyndbg= parameter does need to process the whole cli, for cases like > when $module.dyndbg= is supplied but $module is a builtin. And you are > saying that this syntax (although it works) > 'dyndbg="module params +p #cmt ; module sys +p"' is not the intended > usage. > > So converting dyndbg= to act like ddebug_query= won't work because > $module.dyndbg="+p" should work if $module is builtin or a module > (settles my open discussion with Jason). Egh, sorry for double reply here but I think I got too excited with that realization. $module.dyndbg="+p" won't work if $module is a builtin unless dyndbg= is also on the command line independently. So I'm kind of thinking that the current documentation showing 'dyndbg="module params +p #cmt ; module sys +p"' is correct for params/sys as long as they're builtins. So the whole [1] and [3] in the list below don't quite make sense to me and the questions I had to Jason are still open.... dang. > > I'm going to hold my ground and try and silence the warning, because I > think the kernel parameters interface is well defined enough (kernel > params go before the -- i.e. "these are kernel params -- these are for init" > > With that in mind I'll make a v2 series out of this doing: > 1. Clean up the doc to show intended usage on cli, something like > (params.dyndbg="+p" sys.dyndbg="+p" dyndbg="file init/main.c +p #cmt ; func pc87360_init_device +p") > 2. Remove ddebug_query per Jason's approval > 3. Silence the param with this patch here, with a commit message > updated explaining why dyndbg= needs to be able to process the whole > cli, per Jason > > Please lemme know if there are any strong objections in the meantime and > thanks for the feedback! > > > > > > I agree that dyndbg right now (both dyndbg= and $module.dyndbg=) are > > > "fake" params, but I'd like to remove that message for dyndbg= as it is > > > misleading. The code for module loading luckily already handles it all > > > properly and doesn't warn on proper usage: > > > > > > static int unknown_module_param_cb(char *param, char *val, const char *modname, > > > void *arg) > > > { > > > struct module *mod = arg; > > > int ret; > > > > > > if (strcmp(param, "async_probe") == 0) { > > > mod->async_probe_requested = true; > > > return 0; > > > } > > > > > > /* Check for magic 'dyndbg' arg */ > > > ret = ddebug_dyndbg_module_param_cb(param, val, modname); > > > if (ret != 0) > > > pr_warn("%s: unknown parameter '%s' ignored\n", modname, param); > > > return 0; > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Install a dummy handler to register it. This was chosen instead of the > > > > > > approach the (deprecated) ddebug_query param takes, which is to > > > > > > have a real handler that copies the string taking up a KiB memory. > > > > > > > > > > > > Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters") > > > > > > Signed-off-by: Andrew Halaney > > > > > > --- > > > > > > > > > > > > This is the last valid param I know of that was getting flagged on boot > > > > > > if used correctly. Please let me know if the alternative approach of > > > > > > actually copying the string is preferred and I'll spin that up instead. > > > > > > > > > > > > > > > > Hi Andrew, > > > > > > > > > > So I think you are referring to the string copying that ddebug_query= does. > > > > > I don't think that works for 'dyndbg=' b/c its actually looking through > > > > > the entire command line for stuff like .dyndbg="blah". > > > > > > > > > > So I think what you prposed below makes sense, we could perhaps add a note > > > > > as to why it's a noop. As I mentioned it needs to look through the entire > > > > > string. > > > > > > > > > > > > > > > > Sort of an aside, but what's the policy for removing deprecated cli > > > > > > params? ddebug_query has been deprecated for a very long time now, but I > > > > > > am not sure if removing params like that is considered almost as bad as > > > > > > breaking userspace considering some systems might update their kernels > > > > > > but not the bootloader supplying the param. > > > > > > > > > > I think it's probably ok to remove at this point, especially now that > > > > > we are going to flag it as unknown, right? So I feel like that change > > > > > can logically go with this series if you want as a separate patch. > > > > > > > > > > Thanks, > > > > > > > > > > -Jason > > > > > > > > > > > > > > > > > > > > > > lib/dynamic_debug.c | 12 ++++++++++++ > > > > > > 1 file changed, 12 insertions(+) > > > > > > > > > > > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > > > > > > index cb5abb42c16a..84c16309cc63 100644 > > > > > > --- a/lib/dynamic_debug.c > > > > > > +++ b/lib/dynamic_debug.c > > > > > > @@ -761,6 +761,18 @@ static __init int ddebug_setup_query(char *str) > > > > > > > > > > > > __setup("ddebug_query=", ddebug_setup_query); > > > > > > > > > > > > +/* > > > > > > + * Install a noop handler to make dyndbg look like a normal kernel cli > > > > > param. > > > > > > + * This avoids warnings about dyndbg being an unknown cli param when > > > > > supplied > > > > > > + * by a user. > > > > > > + */ > > > > > > +static __init int dyndbg_setup(char *str) > > > > > > +{ > > > > > > + return 1; > > > > > > +} > > > > > > + > > > > > > +__setup("dyndbg=", dyndbg_setup); > > > > > > + > > > > > > /* > > > > > > * File_ops->write method for /dynamic_debug/control. Gathers > > > > > the > > > > > > * command text from userspace, parses and executes it. > > > > > > > > > > > > > > > >