From: Vladimir Oltean <olteanv@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
George McCollister <george.mccollister@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksij Rempel <linux@rempel-privat.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [RFC PATCH net 2/5] net: dsa: be compatible with masters which unregister on shutdown
Date: Sun, 12 Sep 2021 16:18:37 +0300 [thread overview]
Message-ID: <20210912131837.4i6pzwgn573xutmo@skbuf> (raw)
In-Reply-To: <20210912120932.993440-3-vladimir.oltean@nxp.com>
On Sun, Sep 12, 2021 at 03:09:29PM +0300, Vladimir Oltean wrote:
> +static int b53_mmap_shutdown(struct platform_device *pdev)
> +{
> + struct b53_device *dev = platform_get_drvdata(pdev);
> +
> + if (dev)
> + b53_switch_shutdown(dev);
> +
> + platform_set_drvdata(pdev, NULL);
> +}
> +
> static const struct of_device_id b53_mmap_of_table[] = {
> { .compatible = "brcm,bcm3384-switch" },
> { .compatible = "brcm,bcm6328-switch" },
> @@ -331,6 +343,7 @@ MODULE_DEVICE_TABLE(of, b53_mmap_of_table);
> static struct platform_driver b53_mmap_driver = {
> .probe = b53_mmap_probe,
> .remove = b53_mmap_remove,
> + .shutdown = b53_mmap_shutdown,
> .driver = {
> .name = "b53-switch",
> .of_match_table = b53_mmap_of_table,
I forgot to enable all variants of the b53 driver, and as such, the mmap
version fails to build (the shutdown function should return void, not int).
I will fix this when I send the v2 patch, but I will not send that now,
as I would like to get some feedback on the approach first.
next prev parent reply other threads:[~2021-09-12 13:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 12:09 [RFC PATCH net 0/5] Make DSA switch drivers compatible with masters which unregister on shutdown Vladimir Oltean
2021-09-12 12:09 ` [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Vladimir Oltean
2021-09-12 16:14 ` Florian Fainelli
2021-09-13 13:10 ` Andrew Lunn
2021-09-12 12:09 ` [RFC PATCH net 2/5] net: dsa: be compatible with masters which unregister on shutdown Vladimir Oltean
2021-09-12 13:18 ` Vladimir Oltean [this message]
2021-09-13 13:23 ` Andrew Lunn
2021-09-13 13:31 ` Vladimir Oltean
2021-09-13 13:34 ` Andrew Lunn
2021-09-14 1:30 ` Andrew Lunn
2021-09-13 16:56 ` Florian Fainelli
2021-09-12 12:09 ` [RFC PATCH net 3/5] net: dsa: hellcreek: " Vladimir Oltean
2021-09-13 16:50 ` Florian Fainelli
2021-09-14 8:08 ` Kurt Kanzenbach
2021-09-12 12:09 ` [RFC PATCH net 4/5] net: dsa: microchip: ksz8863: " Vladimir Oltean
2021-09-13 16:51 ` Florian Fainelli
2021-09-12 12:09 ` [RFC PATCH net 5/5] net: dsa: xrs700x: " Vladimir Oltean
2021-09-13 13:38 ` George McCollister
2021-09-13 16:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210912131837.4i6pzwgn573xutmo@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=m.grzeschik@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).