linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3 0/5] virtio: Add virtio-device bindings
@ 2021-07-26  4:51 Viresh Kumar
  2021-07-26  4:51 ` [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
                   ` (4 more replies)
  0 siblings, 5 replies; 22+ messages in thread
From: Viresh Kumar @ 2021-07-26  4:51 UTC (permalink / raw)
  To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
	Jean-Philippe Brucker, Bartosz Golaszewski, Linus Walleij,
	Viresh Kumar
  Cc: Vincent Guittot, Bill Mills, Alex Bennée, Enrico Weigelt,
	metux IT consult, Jie Deng, devicetree, linux-kernel,
	virtualization, Arnd Bergmann, linux-gpio, linux-i2c,
	Wolfram Sang

Hi,

Currently the DT only provides support for following node types for virtio-mmio
nodes:

        virtio_mmio@a000000 {
                dma-coherent;
                interrupts = <0x00 0x10 0x01>;
                reg = <0x00 0xa000000 0x00 0x200>;
                compatible = "virtio,mmio";
        };

Here, each virtio-mmio corresponds to a virtio-device. But there is no way for
other users in the DT to show their dependency on virtio devices.

This patchset provides that support.

The first patch adds virtio-device bindings to allow for device sub-nodes to be
present and the second patch updates the virtio core to update the of_node.

Other patches add bindings for i2c and gpio devices.

Tested on x86 with qemu for arm64.

Pending:
- Arnd suggested that "virtio,deviceXX" may be a better compatible string, while
  I used "virtio,XX" to match what PCI and USB do currently. I didn't change it
  yet to hear Rob's view on the same before making the change, in case he has
  any preferences.

V2/2.1->V3:
- Added review-tags from Arnd and Wolfram.
- Only the 5th patch changed otherwise:
  - Use of_device_is_compatible() instead of keeping a list of devices.
  - Use snprintf (with BUG_ON on return value) to create the compatible string,
    whose length is fixed using "virtio,XXXXXXXX".
  - Use dev_of_node().

V1->V2:
- The changes (both binding and code) are made at virtio level, instead of
  virtio-mmio. This allows the same to be used by all device types, irrespective
  of the transport mechanism.

- Dropped the reg property and used compatible in the form "virtio,<DID>".

- Dropped dt-bindings/virtio/virtio_ids.h.

- Add a patch to sync virtio-ids from spec, required for the last patch.

--
Viresh

Viresh Kumar (5):
  dt-bindings: virtio: Add binding for virtio devices
  dt-bindings: i2c: Add bindings for i2c-virtio
  dt-bindings: gpio: Add bindings for gpio-virtio
  uapi: virtio_ids: Sync ids with specification
  virtio: Bind virtio device to device-tree node

 .../devicetree/bindings/gpio/gpio-virtio.yaml | 60 +++++++++++++++++++
 .../devicetree/bindings/i2c/i2c-virtio.yaml   | 51 ++++++++++++++++
 .../devicetree/bindings/virtio/mmio.yaml      |  2 +-
 .../bindings/virtio/virtio-device.yaml        | 47 +++++++++++++++
 drivers/virtio/virtio.c                       | 57 +++++++++++++++++-
 include/uapi/linux/virtio_ids.h               | 12 ++++
 6 files changed, 225 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
 create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml

-- 
2.31.1.272.g89b43f80a514


^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2021-09-13 16:19 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  4:51 [PATCH V3 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-26  4:51 ` [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-07-26 14:57   ` Rob Herring
2021-07-26 15:53     ` Arnd Bergmann
2021-07-26 20:36       ` Rob Herring
2021-07-26 21:20         ` Arnd Bergmann
2021-07-27  5:09     ` Viresh Kumar
2021-07-26  4:51 ` [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
2021-07-26  8:06   ` Arnd Bergmann
2021-07-26  8:11     ` Arnd Bergmann
2021-07-26  9:21       ` Viresh Kumar
2021-07-26 15:06   ` Rob Herring
2021-07-26  4:51 ` [PATCH V3 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
2021-07-26  8:13   ` Arnd Bergmann
2021-07-26 15:11   ` Rob Herring
2021-07-26  4:51 ` [PATCH V3 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
2021-07-26  4:51 ` [PATCH V3 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
2021-09-13  9:19   ` Alexey Kardashevskiy
2021-09-13  9:45     ` Michael S. Tsirkin
2021-09-13 10:27       ` Alexey Kardashevskiy
2021-09-13 14:49   ` Guenter Roeck
2021-09-13 16:19     ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).