From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5EDC433EF for ; Mon, 13 Sep 2021 09:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36E6360FC0 for ; Mon, 13 Sep 2021 09:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238676AbhIMJeQ (ORCPT ); Mon, 13 Sep 2021 05:34:16 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:57012 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238444AbhIMJeO (ORCPT ); Mon, 13 Sep 2021 05:34:14 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 6F4DD1C0B7A; Mon, 13 Sep 2021 11:32:57 +0200 (CEST) Date: Mon, 13 Sep 2021 11:32:56 +0200 From: Pavel Machek To: Randy Dunlap Cc: Linus Torvalds , Marco Elver , Nick Desaulniers , llvm@lists.linux.dev, LSM List , linux-toolchains@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Kees Cook , Mark Brown , Masahiro Yamada , Nathan Chancellor , Michal Marek , Andrew Morton , Vipin Sharma , Chris Down , Rasmus Villemoes , Daniel Borkmann , Vlastimil Babka , Linux Kbuild mailing list , Linux Kernel Mailing List Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds" Message-ID: <20210913093256.GA12225@amd> References: <20210907183843.33028-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> config WERROR > >> bool "Compile the kernel with warnings as errors" > >>- default y > >>+ default COMPILE_TEST > > > >That seems reasonable. It very much is about build-testing. >=20 > That and 2 more things IMO: >=20 > a. having developers be responsible for build warnings, not just > build errors >=20 > b. having maintainers merge them more like they are build errors > and not just some warnings that can be overlooked. >=20 > I don't see enough of a. or b. :( Do we really want developers treat warnings as errors? When the code is okay but some random version of gcc dislikes it... Plus, there's question of stable. We already get ton of churn there ("this fixes random warning"). WERROR will only encourage that... Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmE/GscACgkQMOfwapXb+vKf6wCeMl/kwYj5SUzbAi0/ynpYblZF 888AoKqSN5XRNc1+75+8cGEAonrC2YAc =uY8f -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--