From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Marco Elver <elver@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
llvm@lists.linux.dev,
LSM List <linux-security-module@vger.kernel.org>,
linux-toolchains@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Guenter Roeck <linux@roeck-us.net>,
Kees Cook <keescook@chromium.org>,
Mark Brown <broonie@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Andrew Morton <akpm@linux-foundation.org>,
Vipin Sharma <vipinsh@google.com>,
Chris Down <chris@chrisdown.name>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Daniel Borkmann <daniel@iogearbox.net>,
Vlastimil Babka <vbabka@suse.cz>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds"
Date: Mon, 13 Sep 2021 12:02:30 +0200 [thread overview]
Message-ID: <20210913100230.GB11752@amd> (raw)
In-Reply-To: <YT8d5a6ZVW7JlsRl@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Hi!
> > Do we really want developers treat warnings as errors? When the code
> > is okay but some random version of gcc dislikes it...
> >
> > Plus, there's question of stable. We already get ton of churn there
> > ("this fixes random warning"). WERROR will only encourage that...
>
> I will not be backporting this patch to older stable kernels, but I
> _want_ to see stable builds build with no warnings. When we add
> warnings, they are almost always things we need to fix up properly.
Well, everyone _wants_ to see clean builds... unless the price is too
high.
> Over time, I have worked to reduce the number of build warnings in older
> stable kernels. For newer versions of gcc, sometimes that is
> impossible, but we are close...
You clearly can't backport this patch, but for 5.16-stable, you'll
have it in, and now warnings are same as errors... and I don't believe
that's good idea for stable.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-09-13 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 18:38 [PATCH] Revert "Enable '-Werror' by default for all kernel builds" Nick Desaulniers
2021-09-07 18:55 ` Fāng-ruì Sòng
2021-09-07 19:16 ` Linus Torvalds
2021-09-07 20:30 ` Nick Desaulniers
2021-09-07 22:14 ` Marco Elver
2021-09-07 22:18 ` Linus Torvalds
2021-09-07 22:33 ` Randy Dunlap
2021-09-13 9:32 ` Pavel Machek
2021-09-13 9:46 ` Greg Kroah-Hartman
2021-09-13 10:02 ` Pavel Machek [this message]
2021-09-13 10:51 ` Greg Kroah-Hartman
2021-09-20 16:26 ` Geert Uytterhoeven
2021-09-13 9:50 ` Florian Weimer
2021-09-13 17:42 ` Linus Torvalds
2021-09-13 14:33 ` Guenter Roeck
2021-09-07 22:28 ` Guenter Roeck
2021-09-07 22:42 ` Segher Boessenkool
2021-09-07 22:55 ` Mark Brown
2021-09-07 23:00 ` Nathan Chancellor
2021-09-07 23:35 ` Mark Brown
2021-09-08 16:12 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913100230.GB11752@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chris@chrisdown.name \
--cc=daniel@iogearbox.net \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).