* RE: [PATCH] bnx2x: Fix enabling network interfaces without VFs
@ 2021-09-13 8:14 Shai Malin
2021-09-13 10:41 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Shai Malin @ 2021-09-13 8:14 UTC (permalink / raw)
To: Adrian Bunk, Ariel Elior, Sudarsana Reddy Kalluru,
GR-everest-linux-l2, netdev, linux-kernel
On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> This function is called to enable SR-IOV when available,
> not enabling interfaces without VFs was a regression.
>
> Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Reported-by: YunQiang Su <wzssyqa@gmail.com>
> Tested-by: YunQiang Su <wzssyqa@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index f255fd0b16db..6fbf735fca31 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> int_mode_param,
>
> /* SR-IOV capability was enabled but there are no VFs*/
> if (iov->total == 0) {
> - err = -EINVAL;
> + err = 0;
> goto failed;
> }
Thanks for reporting this issue!
But the complete fix should also not use "goto failed".
Instead, please create a new "goto skip_vfs" so it will skip
the log of "Failed err=".
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs
2021-09-13 8:14 [PATCH] bnx2x: Fix enabling network interfaces without VFs Shai Malin
@ 2021-09-13 10:41 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2021-09-13 10:41 UTC (permalink / raw)
To: Shai Malin
Cc: Ariel Elior, Sudarsana Reddy Kalluru, GR-everest-linux-l2,
netdev, linux-kernel
On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:
> On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> > This function is called to enable SR-IOV when available,
> > not enabling interfaces without VFs was a regression.
> >
> > Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > Reported-by: YunQiang Su <wzssyqa@gmail.com>
> > Tested-by: YunQiang Su <wzssyqa@gmail.com>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > index f255fd0b16db..6fbf735fca31 100644
> > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> > int_mode_param,
> >
> > /* SR-IOV capability was enabled but there are no VFs*/
> > if (iov->total == 0) {
> > - err = -EINVAL;
> > + err = 0;
> > goto failed;
> > }
>
> Thanks for reporting this issue!
> But the complete fix should also not use "goto failed".
> Instead, please create a new "goto skip_vfs" so it will skip
> the log of "Failed err=".
Is this really desirable?
It is a debug print not enabled by default,
and trying to enable SR-IOV did fail.
cu
Adrian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs
2021-09-13 11:18 Shai Malin
@ 2021-09-15 2:28 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2021-09-15 2:28 UTC (permalink / raw)
To: Shai Malin, Adrian Bunk
Cc: Ariel Elior, Sudarsana Reddy Kalluru, GR-everest-linux-l2,
netdev, linux-kernel
On Mon, 13 Sep 2021 11:18:33 +0000 Shai Malin wrote:
> On 9/12/2021 at 1:42PM, Adrian Bunk Wrote:
> > On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:
> > > Thanks for reporting this issue!
> > > But the complete fix should also not use "goto failed".
> > > Instead, please create a new "goto skip_vfs" so it will skip
> > > the log of "Failed err=".
> >
> > Is this really desirable?
> > It is a debug print not enabled by default,
> > and trying to enable SR-IOV did fail.
>
> I agree.
>
> Acked-by: Shai Malin <smalin@marvell.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] bnx2x: Fix enabling network interfaces without VFs
@ 2021-09-13 11:18 Shai Malin
2021-09-15 2:28 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Shai Malin @ 2021-09-13 11:18 UTC (permalink / raw)
To: Adrian Bunk
Cc: Ariel Elior, Sudarsana Reddy Kalluru, GR-everest-linux-l2,
netdev, linux-kernel
On 9/12/2021 at 1:42PM, Adrian Bunk Wrote:
> On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:
> > On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> > > This function is called to enable SR-IOV when available,
> > > not enabling interfaces without VFs was a regression.
> > >
> > > Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > > Reported-by: YunQiang Su <wzssyqa@gmail.com>
> > > Tested-by: YunQiang Su <wzssyqa@gmail.com>
> > > Cc: stable@vger.kernel.org
> > > ---
> > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > > index f255fd0b16db..6fbf735fca31 100644
> > > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > > @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> > > int_mode_param,
> > >
> > > /* SR-IOV capability was enabled but there are no VFs*/
> > > if (iov->total == 0) {
> > > - err = -EINVAL;
> > > + err = 0;
> > > goto failed;
> > > }
> >
> > Thanks for reporting this issue!
> > But the complete fix should also not use "goto failed".
> > Instead, please create a new "goto skip_vfs" so it will skip
> > the log of "Failed err=".
>
> Is this really desirable?
> It is a debug print not enabled by default,
> and trying to enable SR-IOV did fail.
I agree.
Acked-by: Shai Malin <smalin@marvell.com>
>
> cu
> Adrian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] bnx2x: Fix enabling network interfaces without VFs
@ 2021-09-12 19:05 Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2021-09-12 19:05 UTC (permalink / raw)
To: Ariel Elior, Sudarsana Kalluru, GR-everest-linux-l2, netdev,
linux-kernel
This function is called to enable SR-IOV when available,
not enabling interfaces without VFs was a regression.
Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reported-by: YunQiang Su <wzssyqa@gmail.com>
Tested-by: YunQiang Su <wzssyqa@gmail.com>
Cc: stable@vger.kernel.org
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index f255fd0b16db..6fbf735fca31 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int int_mode_param,
/* SR-IOV capability was enabled but there are no VFs*/
if (iov->total == 0) {
- err = -EINVAL;
+ err = 0;
goto failed;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-15 2:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 8:14 [PATCH] bnx2x: Fix enabling network interfaces without VFs Shai Malin
2021-09-13 10:41 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2021-09-13 11:18 Shai Malin
2021-09-15 2:28 ` Jakub Kicinski
2021-09-12 19:05 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).