From: Vladimir Oltean <olteanv@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Saravana Kannan <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
p.rosenberger@kunbus.com, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, vivien.didelot@gmail.com,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix for KSZ DSA switch shutdown
Date: Mon, 13 Sep 2021 13:44:00 +0300 [thread overview]
Message-ID: <20210913104400.oyib42rfq5x2vc56@skbuf> (raw)
In-Reply-To: <trinity-e5b95a34-015c-451d-bbfc-83bfb0bdecad-1631529134448@3c-app-gmx-bs55>
On Mon, Sep 13, 2021 at 12:32:14PM +0200, Lino Sanfilippo wrote:
> Hi,
>
> > Gesendet: Sonntag, 12. September 2021 um 22:29 Uhr
> > Von: "Vladimir Oltean" <olteanv@gmail.com>
> > An: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
> > Cc: "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Saravana Kannan" <saravanak@google.com>, "Rafael J. Wysocki" <rafael@kernel.org>, p.rosenberger@kunbus.com, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, vivien.didelot@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> > Betreff: Re: [PATCH 0/3] Fix for KSZ DSA switch shutdown
> >
> > On Sun, Sep 12, 2021 at 10:19:24PM +0200, Lino Sanfilippo wrote:
> > >
> > > Hi,
> > >
> > > On 10.09.21 at 16:58, Vladimir Oltean wrote:
> > > > On Fri, Sep 10, 2021 at 01:51:56PM +0200, Andrew Lunn wrote:
> > > >>> It does not really scale but we also don't have that many DSA masters to
> > > >>> support, I believe I can name them all: bcmgenet, stmmac, bcmsysport, enetc,
> > > >>> mv643xx_eth, cpsw, macb.
> > > >>
> > > >> fec, mvneta, mvpp2, i210/igb.
> > > >
> > > > I can probably double that list only with Freescale/NXP Ethernet
> > > > drivers, some of which are not even submitted to mainline. To name some
> > > > mainline drivers: gianfar, dpaa-eth, dpaa2-eth, dpaa2-switch, ucc_geth.
> > > > Also consider that DSA/switchdev drivers can also be DSA masters of
> > > > their own, we have boards doing that too.
> > > >
> > > > Anyway, I've decided to at least try and accept the fact that DSA
> > > > masters will unregister their net_device on shutdown, and attempt to do
> > > > something sane for all DSA switches in that case.
> > > >
> > > > Attached are two patches (they are fairly big so I won't paste them
> > > > inline, and I would like initial feedback before posting them to the
> > > > list).
> > > >
> > > > As mentioned in those patches, the shutdown ordering guarantee is still
> > > > very important, I still have no clue what goes on there, what we need to
> > > > do, etc.
> > > >
> > >
> > > I tested these patches with my 5.10 kernel (based on Gregs 5.10.27 stable
> > > kernel) and while I do not see the message "unregister_netdevice: waiting
> > > for eth0 to become free. Usage count = 2." any more the shutdown/reboot hangs, too.
> > > After a few attempts without any error messages on the console I was able to get a
> > > stack trace. Something still seems to go wrong in bcm2835_spi_shutdown() (see attachment).
> > > I have not had the time yet to investigate this further (or to test the patches
> > > with a newer kernel).
> >
> > Could you post the full kernel output? The picture you've posted is
> > truncated and only shows a WARN_ON in rpi_firmware_transaction and is
> > probably a symptom and not the issue (which is above and not shown).
> >
>
> Unfortunately I dont see anything in the kernel log. The console output is all I get,
> thats why I made the photo.
To clarify, are you saying nothing above this line gets printed? Because
the part of the log you've posted in the picture is pretty much
unworkable:
[ 99.375389] [<bf0dc56c>] (bcm2835_spi_shutdown [spi_bcm2835]) from [<c0863ca0>] (platform_drv_shutdown+0x2c/0x30)
How do you access the device's serial console? Use a program with a
scrollback buffer like GNU screen or something.
next prev parent reply other threads:[~2021-09-13 10:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 9:53 [PATCH 0/3] Fix for KSZ DSA switch shutdown Lino Sanfilippo
2021-09-09 9:53 ` [PATCH 1/3] net: dsa: introduce function dsa_tree_shutdown() Lino Sanfilippo
2021-09-09 9:53 ` [PATCH 2/3] net: dsa: microchip: provide the function ksz_switch_shutdown() Lino Sanfilippo
2021-09-09 9:53 ` [PATCH 3/3] net: dsa: microchip: tear down DSA tree at system shutdown Lino Sanfilippo
2021-09-09 10:14 ` [PATCH 0/3] Fix for KSZ DSA switch shutdown Vladimir Oltean
2021-09-09 11:08 ` Lino Sanfilippo
2021-09-09 11:42 ` Vladimir Oltean
2021-09-09 12:56 ` Vladimir Oltean
2021-09-09 13:19 ` Aw: " Lino Sanfilippo
2021-09-09 14:29 ` Lino Sanfilippo
2021-09-09 15:17 ` Andrew Lunn
2021-09-09 16:41 ` Lino Sanfilippo
2021-09-09 15:11 ` Andrew Lunn
2021-09-09 16:46 ` Lino Sanfilippo
2021-09-09 17:55 ` Andrew Lunn
2021-09-09 15:47 ` Vladimir Oltean
2021-09-09 16:00 ` Florian Fainelli
2021-09-10 1:32 ` Saravana Kannan
2021-09-09 16:37 ` Lino Sanfilippo
2021-09-09 16:44 ` Florian Fainelli
2021-09-09 17:07 ` Lino Sanfilippo
2021-09-09 22:54 ` Vladimir Oltean
2021-09-09 23:23 ` Vladimir Oltean
2021-09-10 1:08 ` Vladimir Oltean
2021-09-10 2:15 ` Florian Fainelli
2021-09-10 11:51 ` Andrew Lunn
2021-09-10 14:58 ` Vladimir Oltean
2021-09-11 11:44 ` Vladimir Oltean
2021-09-12 20:19 ` Lino Sanfilippo
2021-09-12 20:29 ` Vladimir Oltean
2021-09-13 10:32 ` Aw: " Lino Sanfilippo
2021-09-13 10:44 ` Vladimir Oltean [this message]
2021-09-13 11:01 ` Lino Sanfilippo
2021-09-14 18:48 ` Vladimir Oltean
2021-09-15 5:42 ` Lino Sanfilippo
2021-09-18 19:37 ` Lino Sanfilippo
2021-09-18 22:04 ` Vladimir Oltean
2021-09-19 0:29 ` Vladimir Oltean
2021-09-09 12:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913104400.oyib42rfq5x2vc56@skbuf \
--to=olteanv@gmail.com \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.rosenberger@kunbus.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).