From: Marijn Suijten <marijn.suijten@somainline.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, dmitry.baryshkov@linaro.org,
abhinavk@codeaurora.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org,
martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org
Subject: Re: [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels
Date: Mon, 13 Sep 2021 16:14:17 +0200 [thread overview]
Message-ID: <20210913141417.7brqczhagufgqch2@SoMainline.org> (raw)
In-Reply-To: <20210911163919.47173-2-angelogioacchino.delregno@somainline.org>
On 2021-09-11 18:39:19, AngeloGioacchino Del Regno wrote:
> In function dpu_encoder_phys_cmd_wait_for_commit_done we are always
> checking if the relative CTL is started by waiting for an interrupt
> to fire: it is fine to do that, but then sometimes we call this
> function while the CTL is up and has never been put down, but that
> interrupt gets raised only when the CTL gets a state change from
> 0 to 1 (disabled to enabled), so we're going to wait for something
> that will never happen on its own.
>
> Solving this while avoiding to restart the CTL is actually possible
> and can be done by just checking if it is already up and running
> when the wait_for_commit_done function is called: in this case, so,
> if the CTL was already running, we can say that the commit is done
> if the command transmission is complete (in other terms, if the
> interface has been flushed).
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
This has unfortunately not solved any ctl_start timeout issues for me/us
on other platforms yet, but for the code:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index aa01698d6b25..aa5d3b3cef15 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -682,6 +682,9 @@ static int dpu_encoder_phys_cmd_wait_for_commit_done(
> if (!dpu_encoder_phys_cmd_is_master(phys_enc))
> return 0;
>
> + if (phys_enc->hw_ctl->ops.is_started(phys_enc->hw_ctl))
> + return dpu_encoder_phys_cmd_wait_for_tx_complete(phys_enc);
> +
> return _dpu_encoder_phys_cmd_wait_for_ctl_start(phys_enc);
> }
>
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-09-13 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 16:39 [PATCH v2 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status AngeloGioacchino Del Regno
2021-09-11 16:39 ` [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels AngeloGioacchino Del Regno
2021-09-13 14:14 ` Marijn Suijten [this message]
2021-10-01 22:33 ` Dmitry Baryshkov
2021-12-09 17:02 ` AngeloGioacchino Del Regno
2021-12-11 21:35 ` Marijn Suijten
2021-12-11 21:49 ` Dmitry Baryshkov
2021-12-11 21:57 ` Marijn Suijten
2021-12-22 11:28 ` AngeloGioacchino Del Regno
2021-12-22 11:54 ` Marijn Suijten
2022-02-18 17:26 ` Dmitry Baryshkov
2022-02-18 19:27 ` [PATCH v2 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913141417.7brqczhagufgqch2@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=paul.bouchara@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).