From: Mark Brown <firstname.lastname@example.org>
To: Iskren Chernev <email@example.com>
Cc: Bjorn Andersson <firstname.lastname@example.org>,
Andy Gross <email@example.com>,
Liam Girdwood <firstname.lastname@example.org>,
Subject: Re: [RFC PATCH 2/2] regulator: qcom_smd: Add PM6125 regulator support
Date: Mon, 13 Sep 2021 15:32:21 +0100 [thread overview]
Message-ID: <20210913143221.GG4283@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Fri, Sep 03, 2021 at 10:49:52PM +0300, Iskren Chernev wrote:
> On 9/3/21 6:23 PM, Mark Brown wrote:
> > On Sat, Aug 28, 2021 at 02:56:54PM +0300, Iskren Chernev wrote:
> >> NOTE: The sources haven't been determined, so currently each regulator
> >> has it's own source.
> > It would probably be safer to just leave them unspecified for now and
> > then add them as people figure out what's going on rather than putting
> > something incorrect into the DT bindings.
> I didn't expect this patch to be mergeable, so I didn't add the dt-bindings.
If you skip out on basic smell tests like having DT bindings that's
going to inhibit the amount of review you get, once things obviously
aren't going to be merged review tends to get a lot more high level.
> So should I add bindings and just ignore all the sources (add them later)?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-13 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 11:56 [RFC PATCH 0/2] PM6125 regulator support Iskren Chernev
2021-08-28 11:56 ` [RFC PATCH 1/2] regulator: qcom_spmi: Add PM6125 regulators Iskren Chernev
2021-08-28 11:56 ` [RFC PATCH 2/2] regulator: qcom_smd: Add PM6125 regulator support Iskren Chernev
2021-09-03 15:23 ` Mark Brown
2021-09-03 19:49 ` Iskren Chernev
2021-09-13 14:32 ` Mark Brown [this message]
2021-09-03 15:24 ` [RFC PATCH 0/2] " Mark Brown
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).