From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F3BC433EF for ; Mon, 13 Sep 2021 20:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C04B6108B for ; Mon, 13 Sep 2021 20:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243243AbhIMUQr (ORCPT ); Mon, 13 Sep 2021 16:16:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242914AbhIMUQi (ORCPT ); Mon, 13 Sep 2021 16:16:38 -0400 Received: from scorn.kernelslacker.org (scorn.kernelslacker.org [IPv6:2600:3c03:e000:2fb::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED55C061574 for ; Mon, 13 Sep 2021 13:15:22 -0700 (PDT) Received: from [2601:196:4600:6634:ae9e:17ff:feb7:72ca] (helo=wopr.kernelslacker.org) by scorn.kernelslacker.org with esmtp (Exim 4.92) (envelope-from ) id 1mPsMK-0003gs-By; Mon, 13 Sep 2021 16:15:20 -0400 Received: by wopr.kernelslacker.org (Postfix, from userid 1026) id D9A0F5600F9; Mon, 13 Sep 2021 16:15:19 -0400 (EDT) Date: Mon, 13 Sep 2021 16:15:19 -0400 From: Dave Jones To: Heiner Kallweit Cc: Linus Torvalds , Linux Kernel Mailing List , Bjorn Helgaas , "linux-pci@vger.kernel.org" Subject: Re: Linux 5.15-rc1 Message-ID: <20210913201519.GA15726@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Heiner Kallweit , Linus Torvalds , Linux Kernel Mailing List , Bjorn Helgaas , "linux-pci@vger.kernel.org" References: <20210913141818.GA27911@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 08:59:49PM +0200, Heiner Kallweit wrote: > On 13.09.2021 16:18, Dave Jones wrote: > > [ 186.595296] pci 0000:02:00.0: [144d:a800] type 00 class 0x010601 > > [ 186.595351] pci 0000:02:00.0: reg 0x24: [mem 0xdfc10000-0xdfc11fff] > > [ 186.595361] pci 0000:02:00.0: reg 0x30: [mem 0xdfc00000-0xdfc0ffff pref] > > [ 186.595425] pci 0000:02:00.0: PME# supported from D3hot D3cold > > [ 186.735107] pci 0000:02:00.0: VPD access failed. This is likely a firmware bug on this device. Contact the card vendor for a firmware update > > Thanks for the report! The stalls may be related to this one. Device is: > 02:00.0 SATA controller: Samsung Electronics Co Ltd XP941 PCIe SSD (rev 01) > > With an older kernel you may experience the stall when accessing the vpd > attribute of this device in sysfs. > > Maybe the device indicates VPD capability but doesn't actually support it. > Could you please provide the "lspci -vv" output for this device? 02:00.0 SATA controller: Samsung Electronics Co Ltd XP941 PCIe SSD (rev 01) (prog-if 01 [AHCI 1.0]) Subsystem: Samsung Electronics Co Ltd XP941 PCIe SSD Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Capabilities: [160 v1] Latency Tolerance Reporting Max snoop latency: 71680ns Max no snoop latency: 71680ns Kernel driver in use: ahci > And could you please test with the following applied to verify the > assumption? It disables VPD access for this device. > > --- > drivers/pci/vpd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c > index 517789205..fc92e880e 100644 > --- a/drivers/pci/vpd.c > +++ b/drivers/pci/vpd.c > @@ -540,6 +540,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x002f, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005d, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005f, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SAMSUNG, 0xa800, quirk_blacklist_vpd); > /* > * The Amazon Annapurna Labs 0x0031 device id is reused for other non Root Port > * device types, so the quirk is registered for the PCI_CLASS_BRIDGE_PCI class. This didn't help I'm afraid :( It changed the VPD warning, but that's about it... [ 184.235496] pci 0000:02:00.0: calling quirk_blacklist_vpd+0x0/0x22 @ 1 [ 184.235499] pci 0000:02:00.0: [Firmware Bug]: disabling VPD access (can't determine size of non-standard VPD format) [ 184.235501] pci 0000:02:00.0: quirk_blacklist_vpd+0x0/0x22 took 0 usecs Dave