linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Tomasz Figa <tfiga@chromium.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
	<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
	<ming-fan.chen@mediatek.com>, <yi.kuo@mediatek.com>,
	<anthony.huang@mediatek.com>, Ikjoon Jang <ikjn@chromium.org>
Subject: [PATCH v4 08/13] memory: mtk-smi: Add clocks for smi-sub-common
Date: Tue, 14 Sep 2021 19:36:58 +0800	[thread overview]
Message-ID: <20210914113703.31466-9-yong.wu@mediatek.com> (raw)
In-Reply-To: <20210914113703.31466-1-yong.wu@mediatek.com>

SMI sub common only have one output port. thus it has only one gals
clocks(gals0). then, smi-sub-common require the three clocks(apb/smi/gals0)
in has_gals case.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
 drivers/memory/mtk-smi.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 5c2bd5795cfd..58d9f7667490 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -74,10 +74,12 @@ static const char * const mtk_smi_larb_clks[] = {"apb", "smi", "gals"};
 
 /*
  * common: Require these four clocks in has_gals case. Otherwise, only apb/smi are required.
+ * sub common: Require apb/smi/gals0 clocks in has_gals case. Otherwise, only apb/smi are required.
  */
 static const char * const mtk_smi_common_clks[] = {"apb", "smi", "gals0", "gals1"};
 #define MTK_SMI_COM_REQ_CLK_NR		2
 #define MTK_SMI_COM_GALS_REQ_CLK_NR	MTK_SMI_CLK_NR_MAX
+#define MTK_SMI_SUB_COM_GALS_REQ_CLK_NR 3
 
 struct mtk_smi_common_plat {
 	enum mtk_smi_type	type;
@@ -467,8 +469,12 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 	common->dev = dev;
 	common->plat = of_device_get_match_data(dev);
 
-	if (common->plat->has_gals)
-		clk_required = MTK_SMI_COM_GALS_REQ_CLK_NR;
+	if (common->plat->has_gals) {
+		if (common->plat->type == MTK_SMI_GEN2)
+			clk_required = MTK_SMI_COM_GALS_REQ_CLK_NR;
+		else if (common->plat->type == MTK_SMI_GEN2_SUB_COMM)
+			clk_required = MTK_SMI_SUB_COM_GALS_REQ_CLK_NR;
+	}
 	ret = mtk_smi_dts_clk_init(dev, common, mtk_smi_common_clks, clk_required, 0);
 	if (ret)
 		return ret;
-- 
2.18.0


  parent reply	other threads:[~2021-09-14 11:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 11:36 [PATCH v4 00/13] MT8195 SMI support Yong Wu
2021-09-14 11:36 ` [PATCH v4 01/13] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-09-14 11:36 ` [PATCH v4 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-09-21 20:36   ` Rob Herring
2021-09-14 11:36 ` [PATCH v4 03/13] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-10-15 13:38   ` AngeloGioacchino Del Regno
2021-10-15 13:43     ` Krzysztof Kozlowski
2021-10-15 13:47       ` AngeloGioacchino Del Regno
2021-09-14 11:36 ` [PATCH v4 04/13] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-09-14 11:36 ` [PATCH v4 05/13] memory: mtk-smi: Adjust some code position Yong Wu
2021-09-14 11:36 ` [PATCH v4 06/13] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-09-14 11:36 ` [PATCH v4 07/13] memory: mtk-smi: Add device link for smi-sub-common Yong Wu
2021-09-14 11:36 ` Yong Wu [this message]
2021-09-14 11:36 ` [PATCH v4 09/13] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-09-14 11:37 ` [PATCH v4 10/13] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-09-14 11:37 ` [PATCH v4 11/13] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-09-14 11:37 ` [PATCH v4 12/13] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-09-14 11:37 ` [PATCH v4 13/13] MAINTAINERS: Add entry for MediaTek SMI Yong Wu
2021-09-22  6:44 ` [PATCH v4 00/13] MT8195 SMI support Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914113703.31466-9-yong.wu@mediatek.com \
    --to=yong.wu@mediatek.com \
    --cc=anan.sun@mediatek.com \
    --cc=anthony.huang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ikjn@chromium.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ming-fan.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    --cc=will@kernel.org \
    --cc=yi.kuo@mediatek.com \
    --cc=youlin.pei@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).