* [PATCH] power: supply: Specify variations of MAX8903
@ 2021-09-15 11:03 Ramona Alexandra Nechita
2021-10-13 18:03 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Ramona Alexandra Nechita @ 2021-09-15 11:03 UTC (permalink / raw)
To: linux-pm; +Cc: sre, linux-kernel, Ramona Alexandra Nechita
MAX8903 has multiple variations (A-E/G/H/J/N/Y).
Specified them in the Kconfig and in the file comment.
Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
---
drivers/power/supply/Kconfig | 2 +-
drivers/power/supply/max8903_charger.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index c84a7b1caeb6..cca779480b1c 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -442,7 +442,7 @@ config CHARGER_ISP1704
ISP1707/ISP1704 USB transceivers.
config CHARGER_MAX8903
- tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
+ tristate "MAX8903A/B/C/D/E/G/H/J/N/Y Battery DC-DC Charger for USB and Adapter Power"
help
Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
The driver supports controlling charger-enable and current-limit
diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
index 0bd39b0cc257..4e5c669e6607 100644
--- a/drivers/power/supply/max8903_charger.c
+++ b/drivers/power/supply/max8903_charger.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
+ * max8903_charger.c - Maxim 8903A/B/C/D/E/G/H/J/N/Y USB/Adapter Charger Driver
*
* Copyright (C) 2011 Samsung Electronics
* MyungJoo Ham <myungjoo.ham@samsung.com>
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: Specify variations of MAX8903
2021-09-15 11:03 [PATCH] power: supply: Specify variations of MAX8903 Ramona Alexandra Nechita
@ 2021-10-13 18:03 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2021-10-13 18:03 UTC (permalink / raw)
To: Ramona Alexandra Nechita; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
Hi,
On Wed, Sep 15, 2021 at 02:03:40PM +0300, Ramona Alexandra Nechita wrote:
> MAX8903 has multiple variations (A-E/G/H/J/N/Y).
> Specified them in the Kconfig and in the file comment.
>
> Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
> ---
why? I would expect people to identify this as the correct driver
without this list and it's definetly not grepable.
-- Sebastian
> drivers/power/supply/Kconfig | 2 +-
> drivers/power/supply/max8903_charger.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index c84a7b1caeb6..cca779480b1c 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -442,7 +442,7 @@ config CHARGER_ISP1704
> ISP1707/ISP1704 USB transceivers.
>
> config CHARGER_MAX8903
> - tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
> + tristate "MAX8903A/B/C/D/E/G/H/J/N/Y Battery DC-DC Charger for USB and Adapter Power"
> help
> Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
> The driver supports controlling charger-enable and current-limit
> diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
> index 0bd39b0cc257..4e5c669e6607 100644
> --- a/drivers/power/supply/max8903_charger.c
> +++ b/drivers/power/supply/max8903_charger.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
> + * max8903_charger.c - Maxim 8903A/B/C/D/E/G/H/J/N/Y USB/Adapter Charger Driver
> *
> * Copyright (C) 2011 Samsung Electronics
> * MyungJoo Ham <myungjoo.ham@samsung.com>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-13 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 11:03 [PATCH] power: supply: Specify variations of MAX8903 Ramona Alexandra Nechita
2021-10-13 18:03 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).