From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF63BC433F5 for ; Wed, 15 Sep 2021 16:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB1E96112E for ; Wed, 15 Sep 2021 16:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbhIOQmC (ORCPT ); Wed, 15 Sep 2021 12:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbhIOQlw (ORCPT ); Wed, 15 Sep 2021 12:41:52 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1A5C061574 for ; Wed, 15 Sep 2021 09:40:33 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id j18so4219393ioj.8 for ; Wed, 15 Sep 2021 09:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M39BMLgJoah0hObYW15nhFmqQGYkxGWo//c8+a5nxXM=; b=Hxi5qW6FimNnR7uboNkvJjglXp0EIV8F8SQG+TJutCvVa0ejl5j9HaNj5XVfHIHaVe 3czbqEQcLXR7Tu0QvnP/c7zg1Prb6uLc8paWAOojarZGCs4+Qa8tymFmrf7YfdStSpId YkZqZ1WM9GnUwZsTpuwsXqcyoRymQYdj7rIYWgn8mmGomqRKyNjmOyxTeR7CEt7xn+AQ ttFyLWvMVKbfiyIYcSKQB76neHLi8Fa7sCW2N7Kq6PTkOhAlZNB+vpV7eKszt/MDQPfg hIBoBMmWfGi06KnM3wUxHnuIw40GEIP7VwgbpMsROMrpdplVdIU0UVD3MRA4P0+EqnoD pjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M39BMLgJoah0hObYW15nhFmqQGYkxGWo//c8+a5nxXM=; b=tQj7cdDnC7Kb2zzv1JSk5eGhi6dfUzFHo1TgSNG7S1fXyf7ZCO96gDwkeBvmwk/qds hF3q8wwD4yG2dCwkf1gB3LRGIQgLg0MU6YQmyS4k3vS/u0NQwPPwleArG2KxutkKl2He 3hbm2W4hSep8bjnjYZrVBMMeRBcb3vTu+vpgQkUnv0jfLsKKDJGW49F1SkyJ6hld+EY9 zfrU/Bx/axTux8U2LNLB8CUNU3/e8XLETJBTZF9SDzPXJob+tJDlwJZKlwwYqaEZfjGh yqlH3OsqKAtnsqWdB1AKxRifUPBNWx8bV8kk4Z35eQUoc2a4XUMLRogjf1XxRdURb+W6 QSBg== X-Gm-Message-State: AOAM533RbaVqqeCrhGeIiohKVxVrtJlXI0tMYGklWbBY8ZsrSNM8EyGc AzQho4xaYsXRWOoKakXfrx8+I1wM7Cs= X-Google-Smtp-Source: ABdhPJxJ3nPWXnK2kZkI1Ga8fdfydjvdzSBCQA6MdyY6vWK3yiQyYHyy6YkFApdzbxxT8+Lsb6o6Cw== X-Received: by 2002:a6b:6c17:: with SMTP id a23mr799112ioh.110.1631724033042; Wed, 15 Sep 2021 09:40:33 -0700 (PDT) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id a5sm299540ilf.27.2021.09.15.09.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:40:32 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Cc: Jim Cromie Subject: [PATCH v8 04/16] dyndbg: use alt-quotes in vpr-infos, not those user might use Date: Wed, 15 Sep 2021 10:39:45 -0600 Message-Id: <20210915163957.2949166-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210915163957.2949166-1-jim.cromie@gmail.com> References: <20210915163957.2949166-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org `echo $cmd > control` can be finicky with respect to quoting (mostly wrt * expansion), so lets not complicate things by adding our own in debug messages. Quote as <%s> instead of '%s' or \"%s\" Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index fd5aca157aec..eac6c6877277 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -132,7 +132,7 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg) fmtlen--; } - v3pr_info("%s: func=\"%s\" file=\"%s\" module=\"%s\" format=\"%.*s\" lineno=%u-%u\n", + v3pr_info("%s: func=<%s> file=<%s> module=<%s> format=<%.*s> lineno=%u-%u\n", msg, query->function ?: "", query->filename ?: "", @@ -279,7 +279,7 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords) int i; pr_info("split into words:"); for (i = 0; i < nwords; i++) - pr_cont(" \"%s\"", words[i]); + pr_cont(" <%s>", words[i]); pr_cont("\n"); } @@ -419,7 +419,7 @@ static int ddebug_parse_query(char *words[], int nwords, if (parse_linerange(query, arg)) return -EINVAL; } else { - pr_err("unknown keyword \"%s\"\n", keyword); + pr_err("unknown keyword <%s>\n", keyword); return -EINVAL; } if (rc) @@ -449,7 +449,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); + v3pr_info("op=<%c>\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -531,7 +531,7 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - v2pr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*"); + v2pr_info("query %d: <%s> mod:<%s>\n", i, query, modname ?: "*"); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -1000,7 +1000,7 @@ static int ddebug_dyndbg_param_cb(char *param, char *val, static int ddebug_dyndbg_boot_param_cb(char *param, char *val, const char *unused, void *arg) { - vpr_info("bootparam %s=\"%s\"\n", param, val); + vpr_info("bootparam %s=<%s>\n", param, val); return ddebug_dyndbg_param_cb(param, val, NULL, 0); } @@ -1011,7 +1011,7 @@ static int ddebug_dyndbg_boot_param_cb(char *param, char *val, */ int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *module) { - vpr_info("module: %s %s=\"%s\"\n", module, param, val); + vpr_info("module: %s %s=<%s>\n", module, param, val); return ddebug_dyndbg_param_cb(param, val, module, -ENOENT); } @@ -1030,7 +1030,7 @@ int ddebug_remove_module(const char *mod_name) struct ddebug_table *dt, *nextdt; int ret = -ENOENT; - v2pr_info("removing module \"%s\"\n", mod_name); + v2pr_info("removing module <%s>\n", mod_name); mutex_lock(&ddebug_lock); list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) { -- 2.31.1