* [PATCH] arm64: dts: ls1028a: fix eSDHC2 node
@ 2021-09-15 20:22 Michael Walle
2021-10-04 12:42 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Michael Walle @ 2021-09-15 20:22 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Vladimir Oltean, Shawn Guo, Li Yang, Rob Herring, Yangbo Lu,
Yinbo Zhu, Ashish Kumar, Michael Walle
On the LS1028A this instance of the eSDHC controller is intended for
either an eMMC or eSDIO card. It doesn't provide a card detect pin and
its IO voltage is fixed at 1.8V.
Remove the bogus broken-cd property, instead add the non-removable
property. Fix the voltage-ranges property and set it to 1.8V only.
Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index ef771bfad11c..8cee1f79e5c0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -407,9 +407,9 @@ esdhc1: mmc@2150000 {
interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
clock-frequency = <0>; /* fixed up by bootloader */
clocks = <&clockgen QORIQ_CLK_HWACCEL 1>;
- voltage-ranges = <1800 1800 3300 3300>;
+ voltage-ranges = <1800 1800>;
sdhci,auto-cmd12;
- broken-cd;
+ non-removable;
little-endian;
bus-width = <4>;
status = "disabled";
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix eSDHC2 node
2021-09-15 20:22 [PATCH] arm64: dts: ls1028a: fix eSDHC2 node Michael Walle
@ 2021-10-04 12:42 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-10-04 12:42 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Vladimir Oltean,
Li Yang, Rob Herring, Yangbo Lu, Yinbo Zhu, Ashish Kumar
On Wed, Sep 15, 2021 at 10:22:59PM +0200, Michael Walle wrote:
> On the LS1028A this instance of the eSDHC controller is intended for
> either an eMMC or eSDIO card. It doesn't provide a card detect pin and
> its IO voltage is fixed at 1.8V.
>
> Remove the bogus broken-cd property, instead add the non-removable
> property. Fix the voltage-ranges property and set it to 1.8V only.
>
> Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-04 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 20:22 [PATCH] arm64: dts: ls1028a: fix eSDHC2 node Michael Walle
2021-10-04 12:42 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).