From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Chanwoo Choi <cwchoi00@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] extcon: extcon-axp288: use low level P-Unit semaphore lock for axp288 register accesses
Date: Thu, 16 Sep 2021 08:51:42 +0200 [thread overview]
Message-ID: <20210916065140.GA1365@agape.jhs> (raw)
In-Reply-To: <db4648a4-291c-2941-8f76-29a328eaf25e@gmail.com>
Hello Chanwoo,
On Thu, Sep 16, 2021 at 02:12:26AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 21. 9. 10. 오후 4:34, Fabio Aiuto wrote:
> > use low level P-Unit semaphore lock for axp288 register
> > accesses directly and for more than one access a time,
> > to reduce the number of times this semaphore is locked
> > and released which is an expensive operation.
> >
> > i2c-bus to the XPower is shared between the kernel and the
> > SoCs P-Unit. The P-Unit has a semaphore wich the kernel must
> > lock for axp288 register accesses. When the P-Unit semaphore
> > is locked CPU and GPU power states cannot change or the system
> > will freeze.
> >
> > The P-Unit semaphore lock is already managed inside the regmap
> > access logic, but for each access the semaphore is locked and
> > released. So use directly iosf_mbi_(un)block_punit_i2c_access(),
> > we are safe in doing so because nested calls to the same
> > semaphore are turned to nops.
> >
> > Suggested-by: Hans de Goede <hdegoede@redhat.com>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > Changes in v2:
> > - add a new depends on in Kconfig
> > - add Tested-by Reviewed-by tags
> > drivers/extcon/Kconfig | 2 +-
> > drivers/extcon/extcon-axp288.c | 14 ++++++++++++++
> > 2 files changed, 15 insertions(+), 1 deletion(-)
<snip>
> > #define PS_STAT_VBUS_TRIGGER BIT(0)
> > @@ -215,6 +216,8 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info)
> > unsigned int cable = info->previous_cable;
> > bool vbus_attach = false;
> > + iosf_mbi_block_punit_i2c_access();
>
> You have to check the return value of iosf_mbi_block_punit_i2c_access()
ok will send a v2, with all the fixes you pointed out.
<snip>
>
> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi
thank you,
fabio
next prev parent reply other threads:[~2021-09-16 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 7:34 [PATCH v2] extcon: extcon-axp288: use low level P-Unit semaphore lock for axp288 register accesses Fabio Aiuto
2021-09-15 17:12 ` Chanwoo Choi
2021-09-16 6:51 ` Fabio Aiuto [this message]
2021-09-15 17:14 ` Chanwoo Choi
2021-09-16 6:52 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916065140.GA1365@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).