* [mcgrof-next:20210915-firmware-builtin-v2 14/14] lib/test_firmware.c:1085:13: error: too many arguments to function 'firmware_request_builtin'
@ 2021-09-16 1:04 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-16 1:04 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: kbuild-all, linux-kernel, Borislav Petkov
[-- Attachment #1: Type: text/plain, Size: 3235 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210915-firmware-builtin-v2
head: e7307db5fae2ba43c2984040a8329f0089be09d0
commit: e7307db5fae2ba43c2984040a8329f0089be09d0 [14/14] test_firmware: add support for testing built-in firmware
config: parisc-randconfig-r031-20210916 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=e7307db5fae2ba43c2984040a8329f0089be09d0
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210915-firmware-builtin-v2
git checkout e7307db5fae2ba43c2984040a8329f0089be09d0
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
lib/test_firmware.c: In function 'trigger_request_builtin_store':
>> lib/test_firmware.c:1085:13: error: too many arguments to function 'firmware_request_builtin'
1085 | if (firmware_request_builtin(&builtin_test_firmware, test_fw_config->name, NULL, 0)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from lib/test_firmware.c:17:
include/linux/firmware.h:26:20: note: declared here
26 | static inline bool firmware_request_builtin(struct firmware *fw,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/firmware_request_builtin +1085 lib/test_firmware.c
1064
1065 /*
1066 * In order to test this, set CONFIG_FW_LOADER_BUILTIN_FILES to a firmware file
1067 * which will be built into the kernel image. Then echo the name into the
1068 * "trigger_request_builtin" sysfs file of this module.
1069 */
1070 static ssize_t trigger_request_builtin_store(struct device *dev,
1071 struct device_attribute *attr,
1072 const char *buf, size_t count)
1073 {
1074 int rc = -ENOENT;
1075
1076 if (!test_fw_config->name) {
1077 pr_warn("unconfigured firmware settings\n");
1078 return rc;
1079 }
1080
1081 pr_info("loading builtin '%s'\n", test_fw_config->name);
1082
1083 mutex_lock(&test_fw_mutex);
1084
> 1085 if (firmware_request_builtin(&builtin_test_firmware, test_fw_config->name, NULL, 0)) {
1086 test_fw_config->is_builtin = true;
1087 /* This let's us diff against the firmware */
1088 pr_info("loaded: %zu\n", builtin_test_firmware.size);
1089 rc = count;
1090 goto out;
1091 }
1092
1093 pr_info("load of '%s' failed\n", test_fw_config->name);
1094
1095 out:
1096 mutex_unlock(&test_fw_mutex);
1097
1098 return rc;
1099 }
1100 static DEVICE_ATTR_WO(trigger_request_builtin);
1101
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41412 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [mcgrof-next:20210915-firmware-builtin-v2 14/14] lib/test_firmware.c:1085:13: error: too many arguments to function 'firmware_request_builtin'
@ 2021-09-29 5:20 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-29 5:20 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: kbuild-all, linux-kernel, Borislav Petkov
[-- Attachment #1: Type: text/plain, Size: 3237 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210915-firmware-builtin-v2
head: e7307db5fae2ba43c2984040a8329f0089be09d0
commit: e7307db5fae2ba43c2984040a8329f0089be09d0 [14/14] test_firmware: add support for testing built-in firmware
config: xtensa-randconfig-r032-20210928 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=e7307db5fae2ba43c2984040a8329f0089be09d0
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210915-firmware-builtin-v2
git checkout e7307db5fae2ba43c2984040a8329f0089be09d0
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
lib/test_firmware.c: In function 'trigger_request_builtin_store':
>> lib/test_firmware.c:1085:13: error: too many arguments to function 'firmware_request_builtin'
1085 | if (firmware_request_builtin(&builtin_test_firmware, test_fw_config->name, NULL, 0)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from lib/test_firmware.c:17:
include/linux/firmware.h:26:20: note: declared here
26 | static inline bool firmware_request_builtin(struct firmware *fw,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/firmware_request_builtin +1085 lib/test_firmware.c
1064
1065 /*
1066 * In order to test this, set CONFIG_FW_LOADER_BUILTIN_FILES to a firmware file
1067 * which will be built into the kernel image. Then echo the name into the
1068 * "trigger_request_builtin" sysfs file of this module.
1069 */
1070 static ssize_t trigger_request_builtin_store(struct device *dev,
1071 struct device_attribute *attr,
1072 const char *buf, size_t count)
1073 {
1074 int rc = -ENOENT;
1075
1076 if (!test_fw_config->name) {
1077 pr_warn("unconfigured firmware settings\n");
1078 return rc;
1079 }
1080
1081 pr_info("loading builtin '%s'\n", test_fw_config->name);
1082
1083 mutex_lock(&test_fw_mutex);
1084
> 1085 if (firmware_request_builtin(&builtin_test_firmware, test_fw_config->name, NULL, 0)) {
1086 test_fw_config->is_builtin = true;
1087 /* This let's us diff against the firmware */
1088 pr_info("loaded: %zu\n", builtin_test_firmware.size);
1089 rc = count;
1090 goto out;
1091 }
1092
1093 pr_info("load of '%s' failed\n", test_fw_config->name);
1094
1095 out:
1096 mutex_unlock(&test_fw_mutex);
1097
1098 return rc;
1099 }
1100 static DEVICE_ATTR_WO(trigger_request_builtin);
1101
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32245 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-29 5:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 1:04 [mcgrof-next:20210915-firmware-builtin-v2 14/14] lib/test_firmware.c:1085:13: error: too many arguments to function 'firmware_request_builtin' kernel test robot
2021-09-29 5:20 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).