linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* fs/buffer.c:2342:1: warning: the frame size of 2048 bytes is larger than 1024 bytes
@ 2021-09-16  3:26 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-09-16  3:26 UTC (permalink / raw)
  To: Christophe Leroy; +Cc: kbuild-all, linux-kernel, Michael Ellerman

[-- Attachment #1: Type: text/plain, Size: 9294 bytes --]

Hi Christophe,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ff1ffd71d5f0612cf194f5705c671d6b64bf5f91
commit: 4eeef098b43242ed145c83fba9989d586d707589 powerpc/44x: Remove STDBINUTILS kconfig option
date:   8 months ago
config: powerpc-randconfig-r036-20210915 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4eeef098b43242ed145c83fba9989d586d707589
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 4eeef098b43242ed145c83fba9989d586d707589
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/buffer.c: In function 'block_read_full_page':
>> fs/buffer.c:2342:1: warning: the frame size of 2048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    2342 | }
         | ^
--
   fs/ext4/move_extent.c: In function 'mext_page_mkuptodate':
>> fs/ext4/move_extent.c:227:1: warning: the frame size of 2048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     227 | }
         | ^
--
   fs/exfat/fatent.c: In function 'exfat_zeroed_cluster':
>> fs/exfat/fatent.c:277:1: warning: the frame size of 2048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     277 | }
         | ^


vim +2342 fs/buffer.c

8ab22b9abb5c55 Hisashi Hifumi     2008-07-28  2251  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2252  /*
^1da177e4c3f41 Linus Torvalds     2005-04-16  2253   * Generic "read page" function for block devices that have the normal
^1da177e4c3f41 Linus Torvalds     2005-04-16  2254   * get_block functionality. This is most of the block device filesystems.
^1da177e4c3f41 Linus Torvalds     2005-04-16  2255   * Reads the page asynchronously --- the unlock_buffer() and
^1da177e4c3f41 Linus Torvalds     2005-04-16  2256   * set/clear_buffer_uptodate() functions propagate buffer state into the
^1da177e4c3f41 Linus Torvalds     2005-04-16  2257   * page struct once IO has completed.
^1da177e4c3f41 Linus Torvalds     2005-04-16  2258   */
^1da177e4c3f41 Linus Torvalds     2005-04-16  2259  int block_read_full_page(struct page *page, get_block_t *get_block)
^1da177e4c3f41 Linus Torvalds     2005-04-16  2260  {
^1da177e4c3f41 Linus Torvalds     2005-04-16  2261  	struct inode *inode = page->mapping->host;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2262  	sector_t iblock, lblock;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2263  	struct buffer_head *bh, *head, *arr[MAX_BUF_PER_PAGE];
45bce8f3e3436b Linus Torvalds     2012-11-29  2264  	unsigned int blocksize, bbits;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2265  	int nr, i;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2266  	int fully_mapped = 1;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2267  
45bce8f3e3436b Linus Torvalds     2012-11-29  2268  	head = create_page_buffers(page, inode, 0);
45bce8f3e3436b Linus Torvalds     2012-11-29  2269  	blocksize = head->b_size;
45bce8f3e3436b Linus Torvalds     2012-11-29  2270  	bbits = block_size_bits(blocksize);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2271  
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01  2272  	iblock = (sector_t)page->index << (PAGE_SHIFT - bbits);
45bce8f3e3436b Linus Torvalds     2012-11-29  2273  	lblock = (i_size_read(inode)+blocksize-1) >> bbits;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2274  	bh = head;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2275  	nr = 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2276  	i = 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2277  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2278  	do {
^1da177e4c3f41 Linus Torvalds     2005-04-16  2279  		if (buffer_uptodate(bh))
^1da177e4c3f41 Linus Torvalds     2005-04-16  2280  			continue;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2281  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2282  		if (!buffer_mapped(bh)) {
c64610ba585fab Andrew Morton      2005-05-16  2283  			int err = 0;
c64610ba585fab Andrew Morton      2005-05-16  2284  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2285  			fully_mapped = 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2286  			if (iblock < lblock) {
b0cf2321c65991 Badari Pulavarty   2006-03-26  2287  				WARN_ON(bh->b_size != blocksize);
c64610ba585fab Andrew Morton      2005-05-16  2288  				err = get_block(inode, iblock, bh, 0);
c64610ba585fab Andrew Morton      2005-05-16  2289  				if (err)
^1da177e4c3f41 Linus Torvalds     2005-04-16  2290  					SetPageError(page);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2291  			}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2292  			if (!buffer_mapped(bh)) {
eebd2aa355692a Christoph Lameter  2008-02-04  2293  				zero_user(page, i * blocksize, blocksize);
c64610ba585fab Andrew Morton      2005-05-16  2294  				if (!err)
^1da177e4c3f41 Linus Torvalds     2005-04-16  2295  					set_buffer_uptodate(bh);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2296  				continue;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2297  			}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2298  			/*
^1da177e4c3f41 Linus Torvalds     2005-04-16  2299  			 * get_block() might have updated the buffer
^1da177e4c3f41 Linus Torvalds     2005-04-16  2300  			 * synchronously
^1da177e4c3f41 Linus Torvalds     2005-04-16  2301  			 */
^1da177e4c3f41 Linus Torvalds     2005-04-16  2302  			if (buffer_uptodate(bh))
^1da177e4c3f41 Linus Torvalds     2005-04-16  2303  				continue;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2304  		}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2305  		arr[nr++] = bh;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2306  	} while (i++, iblock++, (bh = bh->b_this_page) != head);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2307  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2308  	if (fully_mapped)
^1da177e4c3f41 Linus Torvalds     2005-04-16  2309  		SetPageMappedToDisk(page);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2310  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2311  	if (!nr) {
^1da177e4c3f41 Linus Torvalds     2005-04-16  2312  		/*
^1da177e4c3f41 Linus Torvalds     2005-04-16  2313  		 * All buffers are uptodate - we can set the page uptodate
^1da177e4c3f41 Linus Torvalds     2005-04-16  2314  		 * as well. But not if get_block() returned an error.
^1da177e4c3f41 Linus Torvalds     2005-04-16  2315  		 */
^1da177e4c3f41 Linus Torvalds     2005-04-16  2316  		if (!PageError(page))
^1da177e4c3f41 Linus Torvalds     2005-04-16  2317  			SetPageUptodate(page);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2318  		unlock_page(page);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2319  		return 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  2320  	}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2321  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2322  	/* Stage two: lock the buffers */
^1da177e4c3f41 Linus Torvalds     2005-04-16  2323  	for (i = 0; i < nr; i++) {
^1da177e4c3f41 Linus Torvalds     2005-04-16  2324  		bh = arr[i];
^1da177e4c3f41 Linus Torvalds     2005-04-16  2325  		lock_buffer(bh);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2326  		mark_buffer_async_read(bh);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2327  	}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2328  
^1da177e4c3f41 Linus Torvalds     2005-04-16  2329  	/*
^1da177e4c3f41 Linus Torvalds     2005-04-16  2330  	 * Stage 3: start the IO.  Check for uptodateness
^1da177e4c3f41 Linus Torvalds     2005-04-16  2331  	 * inside the buffer lock in case another process reading
^1da177e4c3f41 Linus Torvalds     2005-04-16  2332  	 * the underlying blockdev brought it uptodate (the sct fix).
^1da177e4c3f41 Linus Torvalds     2005-04-16  2333  	 */
^1da177e4c3f41 Linus Torvalds     2005-04-16  2334  	for (i = 0; i < nr; i++) {
^1da177e4c3f41 Linus Torvalds     2005-04-16  2335  		bh = arr[i];
^1da177e4c3f41 Linus Torvalds     2005-04-16  2336  		if (buffer_uptodate(bh))
^1da177e4c3f41 Linus Torvalds     2005-04-16  2337  			end_buffer_async_read(bh, 1);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2338  		else
2a222ca992c35a Mike Christie      2016-06-05  2339  			submit_bh(REQ_OP_READ, 0, bh);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2340  	}
^1da177e4c3f41 Linus Torvalds     2005-04-16  2341  	return 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16 @2342  }
1fe72eaa0f46a0 H Hartley Sweeten  2009-09-22  2343  EXPORT_SYMBOL(block_read_full_page);
^1da177e4c3f41 Linus Torvalds     2005-04-16  2344  

:::::: The code at line 2342 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33220 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-09-16  3:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16  3:26 fs/buffer.c:2342:1: warning: the frame size of 2048 bytes is larger than 1024 bytes kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).