From: Cai Huoqing <caihuoqing@baidu.com>
To: <caihuoqing@baidu.com>
Cc: Mark Greer <mgreer@animalcreek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] nfc: trf7970a: Make use of the helper function dev_err_probe()
Date: Thu, 16 Sep 2021 23:36:21 +0800 [thread overview]
Message-ID: <20210916153621.16576-1-caihuoqing@baidu.com> (raw)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/nfc/trf7970a.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
index 8890fcd59c39..8459a2735f2c 100644
--- a/drivers/nfc/trf7970a.c
+++ b/drivers/nfc/trf7970a.c
@@ -2067,8 +2067,8 @@ static int trf7970a_probe(struct spi_device *spi)
trf->regulator = devm_regulator_get(&spi->dev, "vin");
if (IS_ERR(trf->regulator)) {
- ret = PTR_ERR(trf->regulator);
- dev_err(trf->dev, "Can't get VIN regulator: %d\n", ret);
+ ret = dev_err_probe(trf->dev, PTR_ERR(trf->regulator),
+ "Can't get VIN regulator\n");
goto err_destroy_lock;
}
@@ -2084,8 +2084,8 @@ static int trf7970a_probe(struct spi_device *spi)
trf->regulator = devm_regulator_get(&spi->dev, "vdd-io");
if (IS_ERR(trf->regulator)) {
- ret = PTR_ERR(trf->regulator);
- dev_err(trf->dev, "Can't get VDD_IO regulator: %d\n", ret);
+ ret = dev_err_probe(trf->dev, PTR_ERR(trf->regulator),
+ "Can't get VDD_IO regulator\n");
goto err_destroy_lock;
}
--
2.25.1
next reply other threads:[~2021-09-16 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 15:36 Cai Huoqing [this message]
2021-09-16 19:27 ` [PATCH] nfc: trf7970a: Make use of the helper function dev_err_probe() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916153621.16576-1-caihuoqing@baidu.com \
--to=caihuoqing@baidu.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).