From: Florian Westphal <fw@strlen.de>
To: Cole Dishington <Cole.Dishington@alliedtelesis.co.nz>
Cc: "fw@strlen.de" <fw@strlen.de>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"pablo@netfilter.org" <pablo@netfilter.org>,
Anthony Lineham <Anthony.Lineham@alliedtelesis.co.nz>,
"shuah@kernel.org" <shuah@kernel.org>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Blair Steven <Blair.Steven@alliedtelesis.co.nz>,
Scott Parlane <Scott.Parlane@alliedtelesis.co.nz>
Subject: Re: [PATCH net v4] net: netfilter: Fix port selection of FTP for NF_NAT_RANGE_PROTO_SPECIFIED
Date: Fri, 17 Sep 2021 16:04:08 +0200 [thread overview]
Message-ID: <20210917140408.GD15906@breakpoint.cc> (raw)
In-Reply-To: <77b0addceb098af07f3bb20fbb708d190ae58b03.camel@alliedtelesis.co.nz>
Cole Dishington <Cole.Dishington@alliedtelesis.co.nz> wrote:
> On Thu, 2021-09-16 at 13:26 +0200, Florian Westphal wrote:
> > >range_info.max_proto.all) {
> > min = 1;
> > max = 65535;
> > range_size = 65535;
> > } else {
> > min = ntohs(nat->range_info.min_proto.all);
> > max = ntohs(nat->range_info.max_proto.all);
> > range_size = max - min + 1;
> > }
>
> The original code defined the range as [ntohs(exp->saved_proto.tcp.port), 65535]. The above would
> cause a change in behaviour, should we try to avoid it?
Oh indeed, oversight on my part. Good question, current loop
is not good either as it might take too long to complete.
Maybe best to limit/cap the range to 128, e.g. try to use port
as-is, then pick a random value between 1024 and 65535 - 128,
make 128 tries and if all is taken, error out.
I will leave it up to you on how you'd like to handle this.
One way would be to make a small preparation patch and then
built the range patch on top of it.
prev parent reply other threads:[~2021-09-17 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 4:10 [PATCH net v4] net: netfilter: Fix port selection of FTP for NF_NAT_RANGE_PROTO_SPECIFIED Cole Dishington
2021-09-16 11:26 ` Florian Westphal
2021-09-16 20:30 ` Cole Dishington
2021-09-17 14:04 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917140408.GD15906@breakpoint.cc \
--to=fw@strlen.de \
--cc=Anthony.Lineham@alliedtelesis.co.nz \
--cc=Blair.Steven@alliedtelesis.co.nz \
--cc=Cole.Dishington@alliedtelesis.co.nz \
--cc=Scott.Parlane@alliedtelesis.co.nz \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).