From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE10C433EF for ; Sat, 18 Sep 2021 17:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACDDE61244 for ; Sat, 18 Sep 2021 17:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238396AbhIRRxU (ORCPT ); Sat, 18 Sep 2021 13:53:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:52872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231576AbhIRRxS (ORCPT ); Sat, 18 Sep 2021 13:53:18 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D9996101B; Sat, 18 Sep 2021 17:51:50 +0000 (UTC) Date: Sat, 18 Sep 2021 18:55:30 +0100 From: Jonathan Cameron To: Joel Stanley Cc: Billy Tsai , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Andrew Jeffery , Philipp Zabel , lgirdwood@gmail.com, Mark Brown , linux-iio@vger.kernel.org, devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , BMC-SW Subject: Re: [v5 04/15] iio: adc: aspeed: Keep model data to driver data. Message-ID: <20210918185530.4f667796@jic23-huawei> In-Reply-To: References: <20210831071458.2334-1-billy_tsai@aspeedtech.com> <20210831071458.2334-5-billy_tsai@aspeedtech.com> <20210905153339.751732cc@jic23-huawei> <20210905155029.3faa2c04@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Sep 2021 03:52:24 +0000 Joel Stanley wrote: > On Sun, 5 Sept 2021 at 14:47, Jonathan Cameron wrote: > > > > On Sun, 5 Sep 2021 15:33:39 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 31 Aug 2021 15:14:47 +0800 > > > Billy Tsai wrote: > > > > > > > Keep the model data pointer to driver data for reducing the usage of > > > > of_device_get_match_data(). > > > > > > > > Signed-off-by: Billy Tsai > > > This one starts to be impacted by the fix (as its in the context). > > > Rather than making a mess of things for linux-next etc I'll hold > > > off on these until that fix is upstream in a few weeks. > > > > > > If I seem to have lost it (it's been known to happen :( ) then > > > feel free to poke me! > > > > Having taken another look at the rest of the series (and Philipp's review) > > please do a v6 starting from this patch. > > I'd recommend against the practice of half applying a series. I have > just spent a good chunk of time looking at v6, and wondering why it > won't apply to any tags in Linus tree nor to next. Hi Joel, In this particular case it may been unwise, but in general it allows me to handle a higher volume of patches than would otherwise be possible. There are of course other approaches, but this one works well for me. I did express to what tree and branch these were being applied + exposed for build tests. > > (It was made worse by the branch you applied them to not being part of > linux-next.) It will be shortly. That was just unfortunate timing because of the end of the merge window and a some issues that 0-day found in other patches in the tree that needed to be fixed up before making a mess in next. Jonathan > > Cheers, > > Joel