From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Sergey Shtylyov <s.shtylyov@omp.ru>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Wolfram Sang <wsa@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.4 059/133] i2c: s3c2410: fix IRQ check
Date: Mon, 20 Sep 2021 18:42:17 +0200 [thread overview]
Message-ID: <20210920163914.582441994@linuxfoundation.org> (raw)
In-Reply-To: <20210920163912.603434365@linuxfoundation.org>
From: Sergey Shtylyov <s.shtylyov@omp.ru>
[ Upstream commit d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 ]
Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful). Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...
Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index bea74aa3f56c..44af640496bb 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1213,7 +1213,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
if (!(i2c->quirks & QUIRK_POLL)) {
i2c->irq = ret = platform_get_irq(pdev, 0);
- if (ret <= 0) {
+ if (ret < 0) {
dev_err(&pdev->dev, "cannot find IRQ\n");
clk_unprepare(i2c->clk);
return ret;
--
2.30.2
next prev parent reply other threads:[~2021-09-20 16:51 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 16:41 [PATCH 4.4 000/133] 4.4.284-rc1 review Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 001/133] ext4: fix race writing to an inline_data file while its xattrs are changing Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 002/133] xtensa: fix kconfig unmet dependency warning for HAVE_FUTEX_CMPXCHG Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 003/133] ARC: fix allnoconfig build warning Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 004/133] qede: Fix memset corruption Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 005/133] cryptoloop: add a deprecation warning Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 006/133] ARM: 8918/2: only build return_address() if needed Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 007/133] ALSA: pcm: fix divide error in snd_pcm_lib_ioctl Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 008/133] ath: Use safer key clearing with key cache entries Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 009/133] ath9k: Clear key cache explicitly on disabling hardware Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 010/133] ath: Export ath_hw_keysetmac() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 011/133] ath: Modify ath_key_delete() to not need full key entry Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 012/133] ath9k: Postpone key cache entry deletion for TXQ frames reference it Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 013/133] media: stkwebcam: fix memory leak in stk_camera_probe Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 014/133] igmp: Add ip_mc_list lock in ip_check_mc_rcu Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 015/133] usb: phy: isp1301: Fix build warning when CONFIG_OF is disabled Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 016/133] USB: serial: mos7720: improve OOM-handling in read_mos_reg() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 017/133] PM / wakeirq: Enable dedicated wakeirq for suspend Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 018/133] [media] tc358743: fix register i2c_rd/wr function fix Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 019/133] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2) Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 020/133] s390/disassembler: correct disassembly lines alignment Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 021/133] mm/kmemleak.c: make cond_resched() rate-limiting more efficient Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 022/133] powerpc/module64: Fix comment in R_PPC64_ENTRY handling Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 023/133] powerpc/boot: Delete unneeded .globl _zimage_start Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 024/133] net: ll_temac: Remove left-over debug message Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 025/133] mm/page_alloc: speed up the iteration of max_order Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 026/133] Revert "btrfs: compression: dont try to compress if we dont have enough pages" Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 027/133] x86/reboot: Limit Dell Optiplex 990 quirk to early BIOS versions Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 028/133] PCI: Call Max Payload Size-related fixup quirks early Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 029/133] crypto: mxs-dcp - Check for DMA mapping errors Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 030/133] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 031/133] power: supply: max17042_battery: fix typo in MAx17042_TOFF Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 032/133] libata: fix ata_host_start() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 033/133] crypto: qat - do not ignore errors from enable_vf2pf_comms() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 034/133] crypto: qat - fix reuse of completion variable Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 035/133] udf_get_extendedattr() had no boundary checks Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 036/133] m68k: emu: Fix invalid free in nfeth_cleanup() Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 037/133] certs: Trigger creation of RSA module signing key if its not an RSA key Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 038/133] media: dvb-usb: fix uninit-value in dvb_usb_adapter_dvb_init Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 039/133] media: dvb-usb: fix uninit-value in vp702x_read_mac_addr Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 040/133] media: go7007: remove redundant initialization Greg Kroah-Hartman
2021-09-20 16:41 ` [PATCH 4.4 041/133] Bluetooth: sco: prevent information leak in sco_conn_defer_accept() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 042/133] tcp: seq_file: Avoid skipping sk during tcp_seek_last_pos Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 043/133] net: cipso: fix warnings in netlbl_cipsov4_add_std Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 044/133] i2c: highlander: add IRQ check Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 045/133] PCI: PM: Enable PME if it can be signaled from D3cold Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 046/133] Bluetooth: increase BTNAMSIZ to 21 chars to fix potential buffer overflow Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 047/133] arm64: dts: exynos: correct GIC CPU interfaces address range on Exynos7 Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 048/133] Bluetooth: fix repeated calls to sco_sock_kill Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 049/133] drm/msm/dsi: Fix some reference counted resource leaks Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 050/133] usb: gadget: udc: at91: add IRQ check Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 051/133] usb: phy: fsl-usb: " Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 052/133] usb: phy: twl6030: add IRQ checks Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 053/133] Bluetooth: Move shutdown callback before flushing tx and rx queue Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 054/133] usb: host: ohci-tmio: add IRQ check Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 055/133] usb: phy: tahvo: " Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 056/133] usb: gadget: mv_u3d: request_irq() after initializing UDC Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 057/133] Bluetooth: add timeout sanity check to hci_inquiry Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 058/133] i2c: iop3xx: fix deferred probing Greg Kroah-Hartman
2021-09-20 16:42 ` Greg Kroah-Hartman [this message]
2021-09-20 16:42 ` [PATCH 4.4 060/133] mmc: dw_mmc: Fix issue with uninitialized dma_slave_config Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 061/133] mmc: moxart: " Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 062/133] CIFS: Fix a potencially linear read overflow Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 063/133] i2c: mt65xx: fix IRQ check Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 064/133] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 065/133] ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 066/133] bcma: Fix memory leak for internally-handled cores Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 067/133] ipv4: make exception cache less predictible Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 068/133] tty: Fix data race between tiocsti() and flush_to_ldisc() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 069/133] KVM: x86: Update vCPUs hv_clock before back to guest when tsc_offset is adjusted Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 070/133] clk: kirkwood: Fix a clocking boot regression Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 071/133] fbmem: dont allow too huge resolutions Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 072/133] rtc: tps65910: Correct driver module alias Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 073/133] PCI/MSI: Skip masking MSI-X on Xen PV Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 074/133] xen: fix setting of max_pfn in shared_info Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 075/133] power: supply: max17042: handle fails of reading status register Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 076/133] VMCI: fix NULL pointer dereference when unmapping queue pair Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 077/133] media: uvc: dont do DMA on stack Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 078/133] media: rc-loopback: return number of emitters rather than error Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 079/133] libata: add ATA_HORKAGE_NO_NCQ_TRIM for Samsung 860 and 870 SSDs Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 080/133] ARM: 9105/1: atags_to_fdt: dont warn about stack size Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 081/133] PCI: Restrict ASMedia ASM1062 SATA Max Payload Size Supported Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 082/133] PCI: Return ~0 data on pciconfig_read() CAP_SYS_ADMIN failure Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 083/133] openrisc: dont printk() unconditionally Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 084/133] pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 085/133] crypto: mxs-dcp - Use sg_mapping_iter to copy data Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 086/133] PCI: Use pci_update_current_state() in pci_enable_device_flags() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 087/133] iio: dac: ad5624r: Fix incorrect handling of an optional regulator Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 088/133] video: fbdev: kyro: fix a DoS bug by restricting user input Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 089/133] netlink: Deal with ESRCH error in nlmsg_notify() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 090/133] Smack: Fix wrong semantics in smk_access_entry() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 091/133] usb: host: fotg210: fix the actual_length of an iso packet Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 092/133] usb: gadget: u_ether: fix a potential null pointer dereference Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 093/133] tty: serial: jsm: hold port lock when reporting modem line changes Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 094/133] bpf/tests: Fix copy-and-paste error in double word test Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 095/133] bpf/tests: Do not PASS tests without actually testing the result Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 096/133] video: fbdev: asiliantfb: Error out if pixclock equals zero Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 097/133] video: fbdev: kyro: " Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 098/133] video: fbdev: riva: " Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 099/133] ipv4: ip_output.c: Fix out-of-bounds warning in ip_copy_addrs() Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 100/133] s390/jump_label: print real address in a case of a jump label bug Greg Kroah-Hartman
2021-09-20 16:42 ` [PATCH 4.4 101/133] serial: 8250: Define RX trigger levels for OxSemi 950 devices Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 102/133] xtensa: ISS: dont panic in rs_init Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 103/133] hvsi: dont panic on tty_register_driver failure Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 104/133] serial: 8250_pci: make setup_port() parameters explicitly unsigned Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 105/133] Bluetooth: skip invalid hci_sync_conn_complete_evt Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 106/133] gpu: drm: amd: amdgpu: amdgpu_i2c: fix possible uninitialized-variable access in amdgpu_i2c_router_select_ddc_port() Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 107/133] ARM: tegra: tamonten: Fix UART pad setting Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 108/133] rpc: fix gss_svc_init cleanup on failure Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 109/133] gfs2: Dont call dlm after protocol is unmounted Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 110/133] mmc: rtsx_pci: Fix long reads when clock is prescaled Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 111/133] cifs: fix wrong release in sess_alloc_buffer() failed path Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 112/133] Revert "USB: xhci: fix U1/U2 handling for hardware with XHCI_INTEL_HOST quirk set" Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 113/133] parport: remove non-zero check on count Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 114/133] ath9k: fix OOB read ar9300_eeprom_restore_internal Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 115/133] net: fix NULL pointer reference in cipso_v4_doi_free Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 116/133] parisc: fix crash with signals and alloca Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 117/133] platform/chrome: cros_ec_proto: Send command again when timeout occurs Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 118/133] bnx2x: Fix enabling network interfaces without VFs Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 119/133] net-caif: avoid user-triggerable WARN_ON(1) Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 120/133] ptp: dp83640: dont define PAGE0 Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 121/133] dccp: dont duplicate ccid when cloning dccp sock Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 122/133] net/l2tp: Fix reference count leak in l2tp_udp_recv_core Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 123/133] r6040: Restore MDIO clock frequency after MAC reset Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 124/133] tipc: increase timeout in tipc_sk_enqueue() Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 125/133] net/af_unix: fix a data-race in unix_dgram_poll Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 126/133] x86/mm: Fix kern_addr_valid() to cope with existing but not present entries Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 127/133] dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 128/133] ethtool: Fix an error code in cxgb2.c Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 129/133] PCI: Sync __pci_register_driver() stub for CONFIG_PCI=n Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 130/133] mtd: rawnand: cafe: Fix a resource leak in the error handling path of cafe_nand_probe() Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 131/133] ARC: export clear_user_page() for modules Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 132/133] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom Greg Kroah-Hartman
2021-09-20 16:43 ` [PATCH 4.4 133/133] net: renesas: sh_eth: Fix freeing wrong tx descriptor Greg Kroah-Hartman
2021-09-20 20:25 ` [PATCH 4.4 000/133] 4.4.284-rc1 review Pavel Machek
2021-09-21 15:35 ` Shuah Khan
2021-09-21 20:30 ` Guenter Roeck
2021-09-22 7:22 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920163914.582441994@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).