linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	UNGLinuxDriver@microchip.com,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH v1 net 0/1] net: mscc: ocelot: broadcast storm fixup
Date: Wed, 22 Sep 2021 19:03:37 -0700	[thread overview]
Message-ID: <20210923020338.1945812-1-colin.foster@in-advantage.com> (raw)

Ocelot ports would still forward out ethernet broadcasts when they were
in the LEARNING or BLOCKING state. This is due to the
ocelot_get_bridge_fwd_mask, which would tell disabled ports to forward
packets out all FORWARDING ports. Broadcast storms would insue.

This patch restores the functionality of disabling forwarding for ports 
that aren't in the FORWARDING state. No more broadcast storms.

Tested and verified on an in-development driver, and Vladimir has done
independent testing and verification on supported hardware.


Vladimir Oltean (1):
  net: mscc: ocelot: fix forwarding from BLOCKING ports remaining
    enabled

 drivers/net/ethernet/mscc/ocelot.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-09-23  2:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  2:03 Colin Foster [this message]
2021-09-23  2:03 ` [PATCH v1 net 1/1] net: mscc: ocelot: fix forwarding from BLOCKING ports remaining enabled Colin Foster
2021-09-23 12:20 ` [PATCH v1 net 0/1] net: mscc: ocelot: broadcast storm fixup patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923020338.1945812-1-colin.foster@in-advantage.com \
    --to=colin.foster@in-advantage.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).