From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 012F9C43217 for ; Thu, 23 Sep 2021 03:41:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFA3A61360 for ; Thu, 23 Sep 2021 03:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239802AbhIWDm2 (ORCPT ); Wed, 22 Sep 2021 23:42:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:42362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239463AbhIWDlC (ORCPT ); Wed, 22 Sep 2021 23:41:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A05961159; Thu, 23 Sep 2021 03:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632368372; bh=Q98ybQcWOxN8G81IMLn0gU6t4j12Of6eAZF3HnSzzaU=; h=From:To:Cc:Subject:Date:From; b=JVoSXeP9GQhyMspPo+2qd20lvUMDSOKr/JtUj5JYR2jEJzdiD574awf0A3dVSoRR/ 3o2YaWY/7PN6FsZ7VyVzb+CmWDRgr1H2AYIqDpWFGej4xgTZAFYcAIXDzSgXg16NeF L5vJGQiWPrvI3Uec01FczHlzY1+K4f8FQnlLtWIfgFMAikOfyY7Pn7AdH8VoLVq8lF fRv8iNaTEQNOVocew2+zgPR3LJUCRYMMBuBMbhpoIcfOhphprolt4I1dBehoRC9qH6 0+GFT4tvrmY2v0LvY3EoV6OmpnZV/AgmSdqVSKjnj2vvglwHCykMp7YfeGO4quZvnN HvOPG7T2mbq1A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sukadev Bhattiprolu , "David S . Miller" , Sasha Levin , mpe@ellerman.id.au, drt@linux.ibm.com, kuba@kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 01/15] ibmvnic: check failover_pending in login response Date: Wed, 22 Sep 2021 23:39:15 -0400 Message-Id: <20210923033929.1421446-1-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sukadev Bhattiprolu [ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ] If a failover occurs before a login response is received, the login response buffer maybe undefined. Check that there was no failover before accessing the login response buffer. Signed-off-by: Sukadev Bhattiprolu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 4008007c2e34..d97641b9928b 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -4038,6 +4038,14 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq, return 0; } + if (adapter->failover_pending) { + adapter->init_done_rc = -EAGAIN; + netdev_dbg(netdev, "Failover pending, ignoring login response\n"); + complete(&adapter->init_done); + /* login response buffer will be released on reset */ + return 0; + } + netdev->mtu = adapter->req_mtu - ETH_HLEN; netdev_dbg(adapter->netdev, "Login Response Buffer:\n"); -- 2.30.2