From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8C4C433F5 for ; Thu, 23 Sep 2021 03:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A486C60FE8 for ; Thu, 23 Sep 2021 03:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240083AbhIWDq6 (ORCPT ); Wed, 22 Sep 2021 23:46:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:42692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239687AbhIWDoW (ORCPT ); Wed, 22 Sep 2021 23:44:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B8D1C61361; Thu, 23 Sep 2021 03:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632368472; bh=t/erUJWZIbkUm0d3B7DgXzNLqzRKp/ba8B0aIr6qg5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aqOu841jv3bhmOdksFqsic8ipNhMolxHh6W82Id4SvakKS1YF/tQ7mgApAc0yiYY1 yOgA0wv6d/yd12JIAXGvOhGspkWYqLDbQ3iCCtPAhCWUCc0e/oz8LSuJ29YPnUzoPW Ea8qLIMnMMdyHUi70oeXhqOpE83HGpn4x8GWrbjO9L2K4xmF7GfgnGaom9+RIEK8sj kWaiNc+2Yg5ZBaQDdGSUyFxn1oFyzQn4KEO/HO/o2+zcAdIPnSoEgccFc9xSsiwMGH 2Us0vJ8M5s4hY4ptW3DuYKZyBMFGIws6nEiTVEi/wOf8plvUzZ8xf1SDv1NrsVlV5p 1MlkcKyN8xNHg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guenter Roeck , Arnd Bergmann , Linus Torvalds , Sasha Levin , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, geert@linux-m68k.org, akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-alpha@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 08/10] alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile Date: Wed, 22 Sep 2021 23:40:51 -0400 Message-Id: <20210923034055.1422059-8-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210923034055.1422059-1-sashal@kernel.org> References: <20210923034055.1422059-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck [ Upstream commit 35a3f4ef0ab543daa1725b0c963eb8c05e3376f8 ] Some drivers pass a pointer to volatile data to virt_to_bus() and virt_to_phys(), and that works fine. One exception is alpha. This results in a number of compile errors such as drivers/net/wan/lmc/lmc_main.c: In function 'lmc_softreset': drivers/net/wan/lmc/lmc_main.c:1782:50: error: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type drivers/atm/ambassador.c: In function 'do_loader_command': drivers/atm/ambassador.c:1747:58: error: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type Declare the parameter of virt_to_phys and virt_to_bus as pointer to volatile to fix the problem. Signed-off-by: Guenter Roeck Acked-by: Arnd Bergmann Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- arch/alpha/include/asm/io.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h index 355aec0867f4..e55a5e6ab460 100644 --- a/arch/alpha/include/asm/io.h +++ b/arch/alpha/include/asm/io.h @@ -60,7 +60,7 @@ extern inline void set_hae(unsigned long new_hae) * Change virtual addresses to physical addresses and vv. */ #ifdef USE_48_BIT_KSEG -static inline unsigned long virt_to_phys(void *address) +static inline unsigned long virt_to_phys(volatile void *address) { return (unsigned long)address - IDENT_ADDR; } @@ -70,7 +70,7 @@ static inline void * phys_to_virt(unsigned long address) return (void *) (address + IDENT_ADDR); } #else -static inline unsigned long virt_to_phys(void *address) +static inline unsigned long virt_to_phys(volatile void *address) { unsigned long phys = (unsigned long)address; @@ -111,7 +111,7 @@ static inline dma_addr_t __deprecated isa_page_to_bus(struct page *page) extern unsigned long __direct_map_base; extern unsigned long __direct_map_size; -static inline unsigned long __deprecated virt_to_bus(void *address) +static inline unsigned long __deprecated virt_to_bus(volatile void *address) { unsigned long phys = virt_to_phys(address); unsigned long bus = phys + __direct_map_base; -- 2.30.2