From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C28C4332F for ; Fri, 24 Sep 2021 09:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9CB66105A for ; Fri, 24 Sep 2021 09:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245233AbhIXJhU (ORCPT ); Fri, 24 Sep 2021 05:37:20 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:37793 "EHLO mail-wr1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237056AbhIXJhS (ORCPT ); Fri, 24 Sep 2021 05:37:18 -0400 Received: by mail-wr1-f54.google.com with SMTP id t8so25513133wrq.4; Fri, 24 Sep 2021 02:35:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KRYfypNkuIY9emLZqiqldN/0eSszJL/L7hkS9k8gfkA=; b=m5D0Vh0cSXUgya5uLyJUhldGjVydqzfU3oy3qz7rf+XJnpR7JiA9dEWUESA6BXNVJE 2UpENO7SBZnyDHF8+W+I2i2iiZxzhrw5c+tEjSZri+gk5i52myIffmCc6KSGCPxiXn4u v+WF0H4BYk8lAPNgCfnyPP1NdI5iJXLgdueS3MVNX89OANwge56ixJiLvXRQGw9I5Yxj nw+dOfBRPR19Gn0fMZ/HuU9c1QT1RYRumJxoXMgvizzBpeTg11d0jGQpiVfcr/Yckr6t 0gYmCqc0jqcF0LXyug1beOzx9dpIzjtbK4Erlp0eeEKQIdqivRrfCZZc4O7vt7ezKvLR oNQA== X-Gm-Message-State: AOAM530IzVGQ3xjtA6qr4xPQsPQJlqI4oZswI4r8Qh1ABSd3M1SNRPri +EbCIyRkM2IW5KXqTZbgA28= X-Google-Smtp-Source: ABdhPJxZFbl9E73RZActKtG/s6A/AvgOlwsJt9fpLYANe1VVnKWPpjD/wU6IN4dT5t+LO4BrDjlYjA== X-Received: by 2002:a1c:4b15:: with SMTP id y21mr1002172wma.183.1632476144529; Fri, 24 Sep 2021 02:35:44 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id j21sm7505008wrd.48.2021.09.24.02.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 02:35:44 -0700 (PDT) Date: Fri, 24 Sep 2021 09:35:42 +0000 From: Wei Liu To: longli@linuxonhyperv.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, Long Li , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Michael Kelley Subject: Re: [Patch v2] PCI: hv: Fix sleep while in non-sleep context when removing child devices from the bus Message-ID: <20210924093542.dac76ugni4cqtsum@liuwe-devbox-debian-v2> References: <1630365207-20616-1-git-send-email-longli@linuxonhyperv.com> <20210831131607.vsjvmr43eei4dsie@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210831131607.vsjvmr43eei4dsie@liuwe-devbox-debian-v2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 01:16:07PM +0000, Wei Liu wrote: > On Mon, Aug 30, 2021 at 04:13:27PM -0700, longli@linuxonhyperv.com wrote: > > From: Long Li > > > > In hv_pci_bus_exit, the code is holding a spinlock while calling > > pci_destroy_slot(), which takes a mutex. > > > > This is not safe for spinlock. Fix this by moving the children to be > > deleted to a list on the stack, and removing them after spinlock is > > released. > > > > Fixes: 94d22763207a ("PCI: hv: Fix a race condition when removing the device") > > > > Cc: "K. Y. Srinivasan" > > Cc: Haiyang Zhang > > Cc: Stephen Hemminger > > Cc: Wei Liu > > Cc: Dexuan Cui > > Cc: Lorenzo Pieralisi > > Cc: Rob Herring > > Cc: "Krzysztof Wilczyński" > > Cc: Bjorn Helgaas > > Cc: Michael Kelley > > Reported-by: Dan Carpenter > > Link: https://lore.kernel.org/linux-hyperv/20210823152130.GA21501@kili/ > > Signed-off-by: Long Li > > Reviewed-by: Wei Liu Applied to hyperv-fixes.