From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFEDFC433EF for ; Fri, 24 Sep 2021 10:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1B126105A for ; Fri, 24 Sep 2021 10:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245675AbhIXK7N (ORCPT ); Fri, 24 Sep 2021 06:59:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244324AbhIXK7J (ORCPT ); Fri, 24 Sep 2021 06:59:09 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AA12C061574; Fri, 24 Sep 2021 03:57:34 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id u18so37581123lfd.12; Fri, 24 Sep 2021 03:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=s17FqViMBOr8Te4pehncbfRy5I9CQXJfZ+kmZOISVmI=; b=h9etuSw1jD93JbwOUW3o4MInJt6oeyweOqViRx2JaKrpBJ36hKeubAJ5Bf8BbdB0ll TkTSbI2q65OmpuOOl5HBYOQgASys9d7IK4137Z0fPmsTGyVm+ZDS5XOg+a4YPkYGDLMl Auz1ekwhzwcSQPZcLekBTcNgIV0+Ki25HkUw9iLBVf+gpRjKcus/UrIGP5OosXiVPYNK hki9i0+Ej9YO7b0072Ntp6VsahNjZgLanQvmvBHlRilrPts2ytBEPCC+WnRgDrQRcgTp LsiOMZfkRl17WxmbsgyqGdipsSMhUmx2rhJ5GAN+tghRskWZP9He3d09h6tf8wMPRTH8 F3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s17FqViMBOr8Te4pehncbfRy5I9CQXJfZ+kmZOISVmI=; b=dBSy4SoPc0M3bAs5ETlltiF7Fh5JleHfofAVZg2XPSjya86gOGzkhdewFJR12IfcFU YAckwYas/80iQuA+KwheVSZnEa5pq981oN4n2xMCHmVWuBHtYwOytF0+xFwbqNMOwB38 sFRgnxha7suZqCY0jKMbqeCJQr8IoujHcP+IKQaxoFM2YToIFqeORwrNwkER9dWgnHHQ Y2sxOtpVuWg3j8GluKi3aa3zglrV946TuAt/OXBIIOa4n6nzLW6aBTEX6KBB5Dxx0lPa 9P8CYpEgwWcTEHrOzZF7TavvKaLhCm6bPMfeo1liHZohaq2uUApy/00JnDzujAXK9Eij Yvng== X-Gm-Message-State: AOAM531hrBAfJ5CusrQVWtiu+AIGKP+UMARvqEqjuhZCKuQ4DOtL3yjr E6ZzE97rIaOYKSdV1LsdhwgspihGgHI= X-Google-Smtp-Source: ABdhPJzenVfwFCRai6X+jcxzqXd58vHhLuJqJKoFAqquzev4tm44s0FiVN8Fd1wDnjDnvrMF4S39dg== X-Received: by 2002:ac2:5f41:: with SMTP id 1mr9048364lfz.79.1632481052882; Fri, 24 Sep 2021 03:57:32 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id w19sm887695ljd.110.2021.09.24.03.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 03:57:32 -0700 (PDT) Date: Fri, 24 Sep 2021 13:57:30 +0300 From: Kari Argillander To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] fs/ntfs3: Refactor locking in inode_operations Message-ID: <20210924105730.2fyzesynznjieddj@kari-VirtualBox> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 23, 2021 at 06:38:39PM +0300, Konstantin Komarov wrote: > Speed up work with dir lock. > Theoretically in successful cases those locks aren't needed at all. > But proving the same for error cases is difficult. > So instead of removing them we just move them. > > V2: > added patch, that fixes logical error in ntfs_create_inode Whole series Reviewed-by: Kari Argillander > > Konstantin Komarov (6): > fs/ntfs3: Fix logical error in ntfs_create_inode > fs/ntfs3: Move ni_lock_dir and ni_unlock into ntfs_create_inode > fs/ntfs3: Refactor ntfs_get_acl_ex for better readability > fs/ntfs3: Pass flags to ntfs_set_ea in ntfs_set_acl_ex > fs/ntfs3: Change posix_acl_equiv_mode to posix_acl_update_mode > fs/ntfs3: Refactoring lock in ntfs_init_acl > > fs/ntfs3/inode.c | 19 ++++++++--- > fs/ntfs3/namei.c | 20 ----------- > fs/ntfs3/xattr.c | 88 +++++++++++++++++------------------------------- > 3 files changed, 46 insertions(+), 81 deletions(-) > > -- > 2.33.0 >