* [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL
@ 2021-09-25 21:59 Colin King
2021-09-26 5:45 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-09-25 21:59 UTC (permalink / raw)
To: SeongJae Park, Andrew Morton, linux-mm; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently a plain integer is being used to nullify the
pointer ctx->kdamond. Use NULL instead. Cleans up sparse
warning:
mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
mm/damon/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 874558a790a0..c8665c80577a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
nr_running_ctxs);
if (IS_ERR(ctx->kdamond)) {
err = PTR_ERR(ctx->kdamond);
- ctx->kdamond = 0;
+ ctx->kdamond = NULL;
}
}
mutex_unlock(&ctx->kdamond_lock);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL
2021-09-25 21:59 [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL Colin King
@ 2021-09-26 5:45 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2021-09-26 5:45 UTC (permalink / raw)
To: Colin King
Cc: SeongJae Park, Andrew Morton, linux-mm, kernel-janitors, linux-kernel
Hello Colin, thank you for the patch!
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a plain integer is being used to nullify the
> pointer ctx->kdamond. Use NULL instead. Cleans up sparse
> warning:
>
> mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 874558a790a0..c8665c80577a 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
> nr_running_ctxs);
> if (IS_ERR(ctx->kdamond)) {
> err = PTR_ERR(ctx->kdamond);
> - ctx->kdamond = 0;
> + ctx->kdamond = NULL;
> }
> }
> mutex_unlock(&ctx->kdamond_lock);
> --
> 2.32.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-26 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25 21:59 [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL Colin King
2021-09-26 5:45 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).