From: Jonathan Cameron <jic23@kernel.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: <lars@metafoo.de>, <pmeerw@pmeerw.net>, <robh+dt@kernel.org>,
<joel@jms.id.au>, <andrew@aj.id.au>, <p.zabel@pengutronix.de>,
<lgirdwood@gmail.com>, <broonie@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<BMC-SW@aspeedtech.com>
Subject: Re: [v7 00/11] Add support for ast2600 ADC
Date: Sun, 26 Sep 2021 12:27:34 +0100 [thread overview]
Message-ID: <20210926122734.2fccf55a@jic23-huawei> (raw)
In-Reply-To: <20210922081520.30580-1-billy_tsai@aspeedtech.com>
On Wed, 22 Sep 2021 16:15:09 +0800
Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> This patch serials make aspeed_adc.c can support ast2600 and backward
> compatible.
Hi Billy,
Series applied to the togreg branch of iio.git and pushed out as testing for
0-day to poke at it.
Note the fix for platform_set_drvdata() is in the fixes branch so there will
be a bit of mess around context for patch 1 but that should all resolve in
a trivial fashion.
Thanks,
Jonathan
>
> Change since v6:
> aspeed_adc.c:
> - Fix the parameter error for aspeed_adc_unregister_fixed_divider.
>
> Change since v5:
> aspeed_adc.c:
> - Use devm_clk_hw_register_divider()
> - Enabling and setting the ADC to normal mode is a necessary flow, so
> take it out of the condition.
>
> Change since v4:
> dt-bindings:
> - Add clocks maxItems.
> - Rename the property to meet the property-units.yaml.
> - Add the description for the difference between adc0 and adc1.
> aspeed_adc.c:
> - Use new property name to get internal reference voltage: units from mv
> to uv.
> - Fix -Wnonnull warning caused by snprintf parameters.
> - Add suffix mv to the vref parameters.
> - Use ARRAY_SIZE instead of 32.
> - Add a reset action for ADC power down and Use devm_iio_device_register.
> - Fix typo error.
> - Separate the offset interface of ch7 when battery sensing enable
>
> Change since v3:
> dt-bindings:
> - Fix properties:aspeed,int_vref_mv type error.
>
> Change since v2:
> dt-bindings:
> - Create a new dt-bindings for ast2600 adc
> aspeed_adc.c:
> - Splits the patch for more details
> - Remove version enum and use the flags in model data to distinguish
> hardware feature
> - Support trimming data get and set.
> - Use devm_add_action_or_reset to simplify probe error handling.
>
> Changes since v1:
> dt-bindings:
> - Fix the aspeed,adc.yaml check error.
> - Add battery-sensing property.
> aspeed_adc.c:
> - Change the init flow:
> Clock and reference voltage setting should be completed before adc
> engine enable.
> - Change the default sampling rate to meet most user case.
> - Add patch #8 to suppoert battery sensing mode.
>
> Billy Tsai (11):
> iio: adc: aspeed: Keep model data to driver data.
> iio: adc: aspeed: Restructure the model data
> iio: adc: aspeed: Add vref config function
> iio: adc: aspeed: Use model_data to set clk scaler.
> iio: adc: aspeed: Use devm_add_action_or_reset.
> iio: adc: aspeed: Support ast2600 adc.
> iio: adc: aspeed: Fix the calculate error of clock.
> iio: adc: aspeed: Add func to set sampling rate.
> iio: adc: aspeed: Add compensation phase.
> iio: adc: aspeed: Support battery sensing.
> iio: adc: aspeed: Get and set trimming data.
>
> drivers/iio/adc/aspeed_adc.c | 554 +++++++++++++++++++++++++++++------
> 1 file changed, 459 insertions(+), 95 deletions(-)
>
prev parent reply other threads:[~2021-09-26 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 8:15 [v7 00/11] Add support for ast2600 ADC Billy Tsai
2021-09-22 8:15 ` [v7 01/11] iio: adc: aspeed: Keep model data to driver data Billy Tsai
2021-09-22 8:15 ` [v7 02/11] iio: adc: aspeed: Restructure the model data Billy Tsai
2021-09-22 8:15 ` [v7 03/11] iio: adc: aspeed: Add vref config function Billy Tsai
2021-09-22 8:15 ` [v7 04/11] iio: adc: aspeed: Use model_data to set clk scaler Billy Tsai
2021-09-22 8:15 ` [v7 05/11] iio: adc: aspeed: Use devm_add_action_or_reset Billy Tsai
2021-09-22 8:15 ` [v7 06/11] iio: adc: aspeed: Support ast2600 adc Billy Tsai
2021-09-22 8:15 ` [v7 07/11] iio: adc: aspeed: Fix the calculate error of clock Billy Tsai
2021-09-22 8:15 ` [v7 08/11] iio: adc: aspeed: Add func to set sampling rate Billy Tsai
2021-09-22 8:15 ` [v7 09/11] iio: adc: aspeed: Add compensation phase Billy Tsai
2021-09-22 8:15 ` [v7 10/11] iio: adc: aspeed: Support battery sensing Billy Tsai
2021-09-22 8:15 ` [v7 11/11] iio: adc: aspeed: Get and set trimming data Billy Tsai
2021-09-26 11:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926122734.2fccf55a@jic23-huawei \
--to=jic23@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).