Re: [PATCH v6 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC

From: Jonathan Cameron <jic23@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>, <linux-iio@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC
Date: Sun, 26 Sep 2021 15:16:07 +0100	[thread overview]
Message-ID: <20210926151607.0c78736f@jic23-huawei> (raw)
In-Reply-To: <20210925020555.129-1-caihuoqing@baidu.com>

On Sat, 25 Sep 2021 10:05:44 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> The NXP i.MX 8QuadXPlus SOC has a new ADC IP. These patches add
> driver support for this ADC.

Hi Cai Huoqing,

Series applies with the changes discussed in replies to patch 1.

Applied to the togreg branch of iio.git which will be initially pushed out as
testing to let 0-day see if it can find anything we missed.

Thanks,

Jonathan

> 
> dt-bindings: iio: adc:
> v1->v2:
>         *Fix some indentation issues.
>         *Mark status as okay.
>         *Change clock2 source.
> v3->v4:
>         *Remove 'status' from examples.
>         *Remove unused 'state'.
>         *Remove interrupts-parent.
>         *Change num of address/size-cells from 1 to 2.
> v4->v5:
>         *Remove unused properties.
> 
> iio: imx8qxp-adc:
> v1->v2:
> 	*Squash patches 1, 2, 3, and 5 into a single patch.
> 	*Add device specific prefix.
> 	*Remove the brackets around individual numbers.
> 	*Make use of FIELD_PREP() and FIELD_GET().
> 	*Remove a lot of cache values.
> 	*Replace mlock with adc->lock.
> 	*Move adc->value read from isr to the completion.
> 	*Set pm_runtime_disable/_put_noidle() before adc_disable.
> 	*Add error handler-err_disable_reg/err_unprepare_clk.
> v2->v3:
> 	*Add "return 0" to adc_runtime_resume().
> v3->v4:
> 	*Sort header file declarations in alphabetical order.
> 	*Remove explicitly cast from "void *".
> 	*Make use of dev_err_probe().
> 	*Add some blank lines to help readability.
> v4->v5:
> 	*Update commit message.
> 	*Remove unused headers.
> 	*Wrap imx8qxp_adc_read_raw() at a shorter line length that helps readability.
> 	*Deal with clock/regulator in probe/remove().
> 	*Use ADC_DRIVER_NAME instead of dev_name(dev).
> 	*Don't use dev_error_probe() without returning -PROBE_DEFER.
> v5->v6:
> 	*Rename the error path labels to indicate the action that will be performed.
> 
> v1 link:
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830172140.414-4-caihuoqing@baidu.com/
> v3 link:
> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210907015724.1377-1-caihuoqing@baidu.com/
> v4 link:
> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210912071334.1745-1-caihuoqing@baidu.com/
> v5 link:
> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210921052821.91-1-caihuoqing@baidu.com/
> 
> Cai Huoqing (3):
>   iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC
>   iio: imx8qxp-adc: dt-bindings: iio: adc: Add binding documentation for
>      NXP IMX8QXP ADC
>   MAINTAINERS: Add the driver info of the NXP IMX8QXP
> 
>  .../bindings/iio/adc/nxp,imx8qxp-adc.yaml     |  78 +++
>  MAINTAINERS                                   |   7 +
>  drivers/iio/adc/Kconfig                       |  10 +
>  drivers/iio/adc/Makefile                      |   1 +
>  drivers/iio/adc/imx8qxp-adc.c                 | 492 ++++++++++++++++++
>  5 files changed, 588 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
>  create mode 100644 drivers/iio/adc/imx8qxp-adc.c
> 