From: Cai Huoqing <caihuoqing@baidu.com>
To: <caihuoqing@baidu.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
"Vladimir Zapolskiy" <vz@mleia.com>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: [PATCH 4/8] iio: dac: ds4424: Make use of the helper function dev_err_probe()
Date: Mon, 27 Sep 2021 16:26:03 +0800 [thread overview]
Message-ID: <20210927082608.859-4-caihuoqing@baidu.com> (raw)
In-Reply-To: <20210927082608.859-1-caihuoqing@baidu.com>
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/iio/dac/ds4424.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
index 79527fbc250a..5a5e967b0be4 100644
--- a/drivers/iio/dac/ds4424.c
+++ b/drivers/iio/dac/ds4424.c
@@ -232,12 +232,9 @@ static int ds4424_probe(struct i2c_client *client,
indio_dev->name = id->name;
data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
- if (IS_ERR(data->vcc_reg)) {
- dev_err(&client->dev,
- "Failed to get vcc-supply regulator. err: %ld\n",
- PTR_ERR(data->vcc_reg));
- return PTR_ERR(data->vcc_reg);
- }
+ if (IS_ERR(data->vcc_reg))
+ return dev_err_probe(&client->dev, PTR_ERR(data->vcc_reg),
+ "Failed to get vcc-supply regulator.\n");
mutex_init(&data->lock);
ret = regulator_enable(data->vcc_reg);
--
2.25.1
next prev parent reply other threads:[~2021-09-27 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 8:26 [PATCH 1/8] iio: dac: ad8801: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-27 8:26 ` [PATCH 2/8] iio: dac: lpc18xx_dac: " Cai Huoqing
2021-09-27 8:26 ` [PATCH 3/8] iio: dac: ltc1660: " Cai Huoqing
2021-09-27 8:26 ` Cai Huoqing [this message]
2021-09-27 8:26 ` [PATCH 5/8] iio: dac: max5821: " Cai Huoqing
2021-09-27 8:26 ` [PATCH 6/8] iio: dac: mcp4922: " Cai Huoqing
2021-09-27 8:26 ` [PATCH 7/8] iio: dac: stm32-dac: " Cai Huoqing
2021-09-27 8:26 ` [PATCH 8/8] iio: dac: ti-dac7311: " Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927082608.859-4-caihuoqing@baidu.com \
--to=caihuoqing@baidu.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.torgue@foss.st.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcus.folkesson@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).