From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C469C4332F for ; Mon, 27 Sep 2021 17:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33B0C60F70 for ; Mon, 27 Sep 2021 17:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235575AbhI0RCT (ORCPT ); Mon, 27 Sep 2021 13:02:19 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:52483 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235412AbhI0RCS (ORCPT ); Mon, 27 Sep 2021 13:02:18 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 4CF5D5805AF; Mon, 27 Sep 2021 13:00:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 27 Sep 2021 13:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=lhvhZkzEG2JTs8VXnXTsprv1HE/ 2QmgnPUJAYjAh5Qo=; b=SxNSGu8Bb6ncOXI85FEF+4ZP09S3cTJQWPymQOFAKq/ bEhfBKMy809nda4QfY7Hzj8u57QNaHaNgS/RVJGVfvKHGDOfMbUJRnzX3MOrE9dP mcJCmw68vUtZksPzPJa2SbwDAa+N5rJF73RHPM+uLLf5fpeuOPYy10DM+iicQrua oGD7N4q8GowRE2xyZa8QOqhOxCfTznZW9WDCrI6GiTYcpFgzACU6j+Fqm+XhnFE1 Xb1+r2NPg6SmWMep52h6pNI/LMktPM7nUuRwSiLBerg3QJgiDtFZG1qQhwMG1kTB /JH7qzxz0YSLcu8p+oh5Msw2ftHZtpt9nF/aO5sIuQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lhvhZk zEG2JTs8VXnXTsprv1HE/2QmgnPUJAYjAh5Qo=; b=QzYKCp3StKXF6V37i8dO/h GpcdLvyPDXhXhs2lOTyYM9vVbp4JnUGERXIlcNw3V/0wkBclQ5dd7IiHVCBnnLmG gftZQ5+reTBA/zno9nLFw1IfRXwgwObWExDxhaTL64YZqLeJolzSZFNZJvMxgceY r9gyVaz5nrnbvSdcUaHPhplgmkFm4g1iF2m3oqZ6iyy8BrssS+2o0HecGxc8iAhq nlcYASFsjj0frfTlrV+crksK5oBWmMd6qO+yWR9pgAI66O9lHPfFONbdYUnQ88bN hdgNq9zTFX1ed/cpkphNs63tX0nJ2YtZheVl+mqhCgntqMqJkh/5UjfJv7ZjItTA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejkedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheei heegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Sep 2021 13:00:35 -0400 (EDT) Date: Mon, 27 Sep 2021 19:00:34 +0200 From: Maxime Ripard To: "H. Nikolaus Schaller" Cc: Paul Cercueil , Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Hans Verkuil , Liam Girdwood , Mark Brown , Paul Boddie , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 05/10] drm/bridge: synopsis: Fix to properly handle HPD Message-ID: <20210927170034.mhv5r2r5gcojc7yn@gilmour> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="se5ukx3kudn4e4kq" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --se5ukx3kudn4e4kq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Sep 27, 2021 at 06:44:23PM +0200, H. Nikolaus Schaller wrote: > It appears that dw-hdmi plugin detection is not properly > propagated unless we call drm_kms_helper_hotplug_event(). >=20 > Maybe drm_bridge_hpd_notify should have been setup to > call this. >=20 > Signed-off-by: H. Nikolaus Schaller > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/= bridge/synopsys/dw-hdmi.c > index f082e14320e1..edea04f80576 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3018,6 +3018,8 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_i= d) > if (hdmi->bridge.dev) { > drm_helper_hpd_irq_event(hdmi->bridge.dev); > drm_bridge_hpd_notify(&hdmi->bridge, status); > + > + drm_kms_helper_hotplug_event(hdmi->bridge.dev); drm_kms_helper_hotplug_event is already called from drm_helper_hpd_irq_event Maxime --se5ukx3kudn4e4kq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYVH4sgAKCRDj7w1vZxhR xY1eAQCsr8ScTO4ZYd2hxMrGCf3WRCg49NwG234OHf/r7wmRSgD/RejL0pc3tJtY pEFsvdgbaEi9RAjgGHjqhF/oTfz1sw8= =Hrc4 -----END PGP SIGNATURE----- --se5ukx3kudn4e4kq--