On Mon, Sep 27, 2021 at 12:23:06PM -0500, Pierre-Louis Bossart wrote: > On 9/27/21 12:10 PM, Mark Brown wrote: > > A quick survey of other drivers suggests that this pattern should be > > factored out into some helpers as it looks like there's several ways of > > implementing it that look very similar but not quite the same... > No disagreement here, we tried really hard to enforce a common pattern > for suspend-resume, but i just noticed that the maxim amp driver is > different on suspend (resume is consistent with the rest). There seem to be several slightly different ways of writing what I think is supposed to be the same thing in _io_init() too.