linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
	Krzysztof Halasa <khalasa@piap.pl>, Arnd Bergmann <arnd@arndb.de>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] mtd: fixup CFI on ixp4xx
Date: Mon, 27 Sep 2021 18:33:28 +0200	[thread overview]
Message-ID: <20210927183328.2f200fc2@xps13> (raw)
In-Reply-To: <20210927141045.1597593-1-arnd@kernel.org>

Hi Arnd,

arnd@kernel.org wrote on Mon, 27 Sep 2021 16:10:37 +0200:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> drivers/mtd/maps/ixp4xx.c requires MTD_CFI_BE_BYTE_SWAP to be set
> in order to compile.
> 
> drivers/mtd/maps/ixp4xx.c:57:4: error: #error CONFIG_MTD_CFI_BE_BYTE_SWAP required
> 
> This patch avoids the #error output by enforcing the policy in
> Kconfig. Not sure if this is the right approach, but it helps doing
> randconfig builds.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Any other ideas for how to address it?

I am fine with the approach. Should I wait for someone else's Ack?

Thanks,
Miquèl

> ---
>  drivers/mtd/chips/Kconfig | 2 ++
>  drivers/mtd/maps/Kconfig  | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
> index aef14990e5f7..19726ebd973d 100644
> --- a/drivers/mtd/chips/Kconfig
> +++ b/drivers/mtd/chips/Kconfig
> @@ -55,12 +55,14 @@ choice
>  	  LITTLE_ENDIAN_BYTE, if the bytes are reversed.
>  
>  config MTD_CFI_NOSWAP
> +	depends on !ARCH_IXP4XX || CPU_BIG_ENDIAN
>  	bool "NO"
>  
>  config MTD_CFI_BE_BYTE_SWAP
>  	bool "BIG_ENDIAN_BYTE"
>  
>  config MTD_CFI_LE_BYTE_SWAP
> +	depends on !ARCH_IXP4XX
>  	bool "LITTLE_ENDIAN_BYTE"
>  
>  endchoice
> diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
> index aaa164b977fe..4945caa88345 100644
> --- a/drivers/mtd/maps/Kconfig
> +++ b/drivers/mtd/maps/Kconfig
> @@ -302,7 +302,7 @@ config MTD_DC21285
>  
>  config MTD_IXP4XX
>  	tristate "CFI Flash device mapped on Intel IXP4xx based systems"
> -	depends on MTD_CFI && MTD_COMPLEX_MAPPINGS && ARCH_IXP4XX
> +	depends on MTD_CFI && MTD_COMPLEX_MAPPINGS && ARCH_IXP4XX && MTD_CFI_ADV_OPTIONS
>  	help
>  	  This enables MTD access to flash devices on platforms based
>  	  on Intel's IXP4xx family of network processors such as the


  reply	other threads:[~2021-09-27 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 14:10 [PATCH] [RFC] mtd: fixup CFI on ixp4xx Arnd Bergmann
2021-09-27 16:33 ` Miquel Raynal [this message]
2021-09-27 20:30   ` Arnd Bergmann
2021-09-27 23:27 ` Linus Walleij
2021-09-28  7:21   ` Arnd Bergmann
2021-10-15 10:31 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927183328.2f200fc2@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=kaloz@openwrt.org \
    --cc=khalasa@piap.pl \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).