From: Jacopo Mondi <jacopo@jmondi.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Vladimir Barinov" <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v2] media: rcar-vin: add G/S_PARM ioctls
Date: Tue, 28 Sep 2021 10:43:23 +0200 [thread overview]
Message-ID: <20210928084323.5vuhvkp6ev2emv2z@uno.localdomain> (raw)
In-Reply-To: <20210924135138.29950-1-nikita.yoush@cogentembedded.com>
Hello
explicit Cc Hans, as I recall the usage of s/g_parm was deprecated
and discouraged in mainline.
Hans: Support for g/s_param is required by Nikita to maintain
compatibility with (out of tree?) subdevice drivers. Should we add it
to the mainline receiver driver ?
What other API should be used to control the subdevice framerate ?
Should it go through VIDIOC_SUBDEV_S_FRAME_INTERVAL instead ?
Thanks
j
On Fri, Sep 24, 2021 at 04:51:38PM +0300, Nikita Yushchenko wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> This adds g/s_parm ioctls for parallel interface.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> Changes from v1:
> - use &vin->vdev to access vin's struct video_device
>
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> index bdeff51bf768..a5bfa76fdac6 100644
> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> @@ -527,6 +527,24 @@ static int rvin_s_selection(struct file *file, void *fh,
> return 0;
> }
>
> +static int rvin_g_parm(struct file *file, void *priv,
> + struct v4l2_streamparm *parm)
> +{
> + struct rvin_dev *vin = video_drvdata(file);
> + struct v4l2_subdev *sd = vin_to_source(vin);
> +
> + return v4l2_g_parm_cap(&vin->vdev, sd, parm);
> +}
> +
> +static int rvin_s_parm(struct file *file, void *priv,
> + struct v4l2_streamparm *parm)
> +{
> + struct rvin_dev *vin = video_drvdata(file);
> + struct v4l2_subdev *sd = vin_to_source(vin);
> +
> + return v4l2_s_parm_cap(&vin->vdev, sd, parm);
> +}
> +
> static int rvin_g_pixelaspect(struct file *file, void *priv,
> int type, struct v4l2_fract *f)
> {
> @@ -743,6 +761,9 @@ static const struct v4l2_ioctl_ops rvin_ioctl_ops = {
> .vidioc_g_selection = rvin_g_selection,
> .vidioc_s_selection = rvin_s_selection,
>
> + .vidioc_g_parm = rvin_g_parm,
> + .vidioc_s_parm = rvin_s_parm,
> +
> .vidioc_g_pixelaspect = rvin_g_pixelaspect,
>
> .vidioc_enum_input = rvin_enum_input,
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-09-28 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:41 [PATCH] media: rcar-vin: add G/S_PARM ioctls Nikita Yushchenko
2021-09-24 9:54 ` Niklas Söderlund
2021-09-24 13:48 ` Nikita Yushchenko
2021-09-24 13:51 ` [PATCH v2] " Nikita Yushchenko
2021-09-28 0:03 ` Niklas Söderlund
2021-09-28 8:43 ` Jacopo Mondi [this message]
2021-10-12 7:33 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928084323.5vuhvkp6ev2emv2z@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).