From: Cai Huoqing <caihuoqing@baidu.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <horatiu.vultur@microchip.com>, <hkallweit1@gmail.com>,
<linux@armlinux.org.uk>, <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: mdio-ipq4019: Fix the error for an optional regs resource
Date: Wed, 29 Sep 2021 11:11:02 +0800 [thread overview]
Message-ID: <20210929031102.GA2262@LAPTOP-UKSR4ENP.internal.baidu.com> (raw)
In-Reply-To: <YVMZOy6gPhZCKIvy@lunn.ch>
On 28 9月 21 15:31:39, Andrew Lunn wrote:
> On Tue, Sep 28, 2021 at 09:21:57PM +0800, Cai Huoqing wrote:
> > The second resource is optional which is only provided on the chipset
> > IPQ5018. But the blamed commit ignores that and if the resource is
> > not there it just fails.
> >
> > the resource is used like this,
> > if (priv->eth_ldo_rdy) {
> > val = readl(priv->eth_ldo_rdy);
> > val |= BIT(0);
> > writel(val, priv->eth_ldo_rdy);
> > fsleep(IPQ_PHY_SET_DELAY_US);
> > }
> >
> > This patch reverts that to still allow the second resource to be optional
> > because other SoC have the some MDIO controller and doesn't need to
> > second resource.
> >
> > Fix Commit fa14d03e014a ("net: mdio-ipq4019: Make use of
> > devm_platform_ioremap_resource()")
>
> This is not a valid Fixes: tag.
>
> Add to your ~/.gitconfig and add:
>
> [pretty]
> fixes = Fixes: %h (\"%s\")
>
> You can then do
>
> git log --pretty=fixes fa14d03e014a
>
Cool, it is a great help to me:)
Thanks,
Cai
> and get:
>
> Fixes: fa14d03e014a ("net: mdio-ipq4019: Make use of devm_platform_ioremap_resource()")
>
> Which is the correct format. Don't wrap it, if it is long.
>
> Andrew
prev parent reply other threads:[~2021-09-29 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 13:21 [PATCH] net: mdio-ipq4019: Fix the error for an optional regs resource Cai Huoqing
2021-09-28 13:31 ` Andrew Lunn
2021-09-29 3:11 ` Cai Huoqing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929031102.GA2262@LAPTOP-UKSR4ENP.internal.baidu.com \
--to=caihuoqing@baidu.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).