From: Jakub Kicinski <kuba@kernel.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, buytenh@marvell.com, afleming@freescale.com,
dan.carpenter@oracle.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 2/2] phy: mdio: fix memory leak
Date: Wed, 29 Sep 2021 16:48:40 -0700 [thread overview]
Message-ID: <20210929164840.76afdec8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <55e9785e2ae2eae03c4af850a07e3297c5a0b784.1632861239.git.paskripkin@gmail.com>
On Tue, 28 Sep 2021 23:40:15 +0300 Pavel Skripkin wrote:
> + /* We need to set state to MDIOBUS_UNREGISTERED to correctly realese
> + * the device in mdiobus_free()
> + *
> + * State will be updated later in this function in case of success
> + */
> + bus->state == MDIOBUS_UNREGISTERED;
IDK how syzbot has tested it but clearly we should blindly
depend on that.
s/==/=/
Compiler would have told you this.
next prev parent reply other threads:[~2021-09-29 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 11:20 [PATCH] " Pavel Skripkin
2021-09-27 19:17 ` Pavel Skripkin
2021-09-28 20:39 ` [PATCH v2 1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register" Pavel Skripkin
2021-09-28 20:40 ` [PATCH v2 2/2] phy: mdio: fix memory leak Pavel Skripkin
2021-09-29 6:22 ` Dan Carpenter
2021-09-29 23:48 ` Jakub Kicinski [this message]
2021-09-30 5:55 ` Pavel Skripkin
2021-09-29 6:32 ` [PATCH v2 1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register" Xu, Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929164840.76afdec8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=afleming@freescale.com \
--cc=andrew@lunn.ch \
--cc=buytenh@marvell.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com \
--subject='Re: [PATCH v2 2/2] phy: mdio: fix memory leak' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).