From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 1/6] dyndbg: recode for stronger precondition
Date: Wed, 29 Sep 2021 12:37:30 -0600 [thread overview]
Message-ID: <20210929183735.6630-2-jim.cromie@gmail.com> (raw)
In-Reply-To: <20210929183735.6630-1-jim.cromie@gmail.com>
The table of struct _ddebugs, due to its construction by the linker,
has an important property; namely that its "equal" fields have actual
ptr-equality, not just strcmp-equality. Lets recognize that truth in
dynamic_debug_init(), while slicing the builtin table into a
per-module list.
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index cb5abb42c16a..817a87e9c37f 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1101,7 +1101,7 @@ static int __init dynamic_debug_init(void)
iter_start = iter;
for (; iter < __stop___dyndbg; iter++) {
entries++;
- if (strcmp(modname, iter->modname)) {
+ if (modname != iter->modname) {
modct++;
ret = ddebug_add_module(iter_start, n, modname);
if (ret)
--
2.31.1
next prev parent reply other threads:[~2021-09-29 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 18:37 [PATCH 0/6] dyndbg updates for 5.15-rcX Jim Cromie
2021-09-29 18:37 ` Jim Cromie [this message]
2021-09-30 6:06 ` [PATCH 1/6] dyndbg: recode for stronger precondition Greg KH
2021-09-29 18:37 ` [PATCH 2/6] dyndbg: show module in vpr-info in dd-exec-queries Jim Cromie
2021-09-29 18:37 ` [PATCH 3/6] dyndbg: rationalize verbosity Jim Cromie
2021-09-30 6:10 ` Greg KH
2021-10-02 20:58 ` jim.cromie
2021-09-29 18:37 ` [PATCH 4/6] dyndbg: use alt-quotes in vpr-infos, not those user might use Jim Cromie
2021-09-29 18:37 ` [PATCH 5/6] dyndbg: vpr-info on remove-module complete, not starting Jim Cromie
2021-09-29 18:37 ` [PATCH 6/6] dyndbg: no vpr-info on empty queries Jim Cromie
2021-09-30 6:05 ` [PATCH 0/6] dyndbg updates for 5.15-rcX Greg KH
2021-09-30 21:33 ` jim.cromie
2021-10-01 7:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929183735.6630-2-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).