From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Johan Hovold <johan@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCHv2 0/4] Get rid of pm_runtime_irq_safe() for 8250_omap
Date: Thu, 30 Sep 2021 09:29:02 +0300 [thread overview]
Message-ID: <20210930062906.58937-1-tony@atomide.com> (raw)
Hi,
Here are v2 patches to get rid of pm_runtime_irq_safe() for the 8250_omap
driver. Based on comments from Andy and Johan, I improved a bunch of
things as listed below.
For removing the pm_runtime_irq_safe() usage, serial TX is the last
remaining issue. We deal with TX by waking up the port and returning 0
bytes written from write_room() and write() if the port is not available
because of PM runtime autoidle.
This series also removes the dependency to Andy's pending generic serial
layer PM runtime patches, and hopefully makes that work a bit easier :)
Regards,
Tony
Changes since v1:
- Separated out line discipline patches, n_tty -EAGAIN change I still
need to retest
- Changed prep_tx() to more generic wakeup() as also flow control needs it
- Changed over to using wakeup() with device driver runtime PM instead
of write_room()
- Added runtime_suspended flag for drivers and generic serial layer PM
to use
Tony Lindgren (4):
serial: core: Add wakeup() and start_pending_tx() for power management
serial: 8250: Implement wakeup for TX and use it for 8250_omap
serial: 8250_omap: Require a valid wakeirq for deeper idle states
serial: 8250_omap: Drop the use of pm_runtime_irq_safe()
Documentation/driver-api/serial/driver.rst | 9 ++++
drivers/tty/serial/8250/8250_omap.c | 42 +++++++++++-----
drivers/tty/serial/8250/8250_port.c | 35 +++++++++++++-
drivers/tty/serial/serial_core.c | 56 +++++++++++++++++++++-
include/linux/serial_core.h | 3 ++
5 files changed, 131 insertions(+), 14 deletions(-)
--
2.33.0
next reply other threads:[~2021-09-30 6:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 6:29 Tony Lindgren [this message]
2021-09-30 6:29 ` [PATCH 1/4] serial: core: Add wakeup() and start_pending_tx() for power management Tony Lindgren
2021-09-30 7:10 ` Andy Shevchenko
2021-09-30 7:26 ` Tony Lindgren
2021-10-13 12:33 ` Greg Kroah-Hartman
2021-10-15 9:13 ` Tony Lindgren
2021-09-30 6:29 ` [PATCH 2/4] serial: 8250: Implement wakeup for TX and use it for 8250_omap Tony Lindgren
2021-09-30 7:17 ` Andy Shevchenko
2021-09-30 7:29 ` Tony Lindgren
2021-09-30 6:29 ` [PATCH 3/4] serial: 8250_omap: Require a valid wakeirq for deeper idle states Tony Lindgren
2021-09-30 6:29 ` [PATCH 4/4] serial: 8250_omap: Drop the use of pm_runtime_irq_safe() Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930062906.58937-1-tony@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).