linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes
@ 2021-10-01  7:34 Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 1/5] arm: dts: omap3-gta04: cleanup LCD definition Andreas Kemnade
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

This series fixes some errors found by make dtbs_check. Most
do not fix functional issues, just syntax but one typo was
unveiled by make dtbs_check which only caused no problems by
luck.

Andreas Kemnade (5):
  arm: dts: omap3-gta04: cleanup LCD definition
  arm: dts: omap3-gta04: fix missing sensor supply
  arm: dts: omap3-gta04a5: fix missing sensor supply
  arm: dts: omap3-gta04a4: accelerometer irq fix
  arm: dts: omap3-gta04: cleanup led node names

 arch/arm/boot/dts/omap3-gta04.dtsi  | 23 +++++++++++++----------
 arch/arm/boot/dts/omap3-gta04a5.dts |  2 ++
 2 files changed, 15 insertions(+), 10 deletions(-)

-- 
2.30.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/5] arm: dts: omap3-gta04: cleanup LCD definition
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
@ 2021-10-01  7:34 ` Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 2/5] arm: dts: omap3-gta04: fix missing sensor supply Andreas Kemnade
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

Replace depreciated nodenames, fix label name to match scheme.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 938cc691bb2f..9ccd45599104 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -104,16 +104,16 @@ gtm601_codec: gsm_codec {
 		#sound-dai-cells = <0>;
 	};
 
-	spi_lcd: spi_lcd {
+	spi_lcd: spi {
 		compatible = "spi-gpio";
 		#address-cells = <0x1>;
 		#size-cells = <0x0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&spi_gpio_pins>;
 
-		gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
-		gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
-		gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
+		sck-gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>;
+		miso-gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>;
+		mosi-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
 		cs-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
 		num-chipselects = <1>;
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/5] arm: dts: omap3-gta04: fix missing sensor supply
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 1/5] arm: dts: omap3-gta04: cleanup LCD definition Andreas Kemnade
@ 2021-10-01  7:34 ` Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 3/5] arm: dts: omap3-gta04a5: " Andreas Kemnade
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

Add mandatory supply properties. The supply is always on, so it is just
a syntax issue, no functional change.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 9ccd45599104..ca6c95b432b5 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -508,6 +508,8 @@ bmp085@77 {
 		pinctrl-0 = <&bmp085_pins>;
 		interrupt-parent = <&gpio4>;
 		interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* GPIO_113 */
+		vdda-supply = <&vio>;
+		vddd-supply = <&vio>;
 	};
 
 	/* accelerometer */
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/5] arm: dts: omap3-gta04a5: fix missing sensor supply
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 1/5] arm: dts: omap3-gta04: cleanup LCD definition Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 2/5] arm: dts: omap3-gta04: fix missing sensor supply Andreas Kemnade
@ 2021-10-01  7:34 ` Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 4/5] arm: dts: omap3-gta04a4: accelerometer irq fix Andreas Kemnade
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

Add mandatory supply properties. The supply is always on, so it is just
a syntax issue, no functional change.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04a5.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
index 9ce8d81250aa..a2ba4030cf27 100644
--- a/arch/arm/boot/dts/omap3-gta04a5.dts
+++ b/arch/arm/boot/dts/omap3-gta04a5.dts
@@ -133,5 +133,7 @@ bmc150@12 {
 	bme280@76 {
 		compatible = "bosch,bme280";
 		reg = <0x76>;
+		vdda-supply = <&vio>;
+		vddd-supply = <&vio>;
 	};
 };
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 4/5] arm: dts: omap3-gta04a4: accelerometer irq fix
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
                   ` (2 preceding siblings ...)
  2021-10-01  7:34 ` [PATCH 3/5] arm: dts: omap3-gta04a5: " Andreas Kemnade
@ 2021-10-01  7:34 ` Andreas Kemnade
  2021-10-01  7:34 ` [PATCH 5/5] arm: dts: omap3-gta04: cleanup led node names Andreas Kemnade
  2021-10-06  7:46 ` [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Tony Lindgren
  5 siblings, 0 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

Fix typo in pinctrl. It did only work because the bootloader
seems to have initialized it.

Fixes: ee327111953b ("ARM: dts: omap3-gta04: Define and use bma180 irq pin")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index ca6c95b432b5..61c0667864b3 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -517,7 +517,7 @@ bma180@41 {
 		compatible = "bosch,bma180";
 		reg = <0x41>;
 		pinctrl-names = "default";
-		pintcrl-0 = <&bma180_pins>;
+		pinctrl-0 = <&bma180_pins>;
 		interrupt-parent = <&gpio4>;
 		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_115 */
 	};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 5/5] arm: dts: omap3-gta04: cleanup led node names
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
                   ` (3 preceding siblings ...)
  2021-10-01  7:34 ` [PATCH 4/5] arm: dts: omap3-gta04a4: accelerometer irq fix Andreas Kemnade
@ 2021-10-01  7:34 ` Andreas Kemnade
  2021-10-06  7:46 ` [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Tony Lindgren
  5 siblings, 0 replies; 7+ messages in thread
From: Andreas Kemnade @ 2021-10-01  7:34 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, hns, linux-omap, devicetree,
	linux-kernel, letux-kernel
  Cc: Andreas Kemnade

Change led node names to match schema.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 61c0667864b3..7e3d8147e2c1 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -542,28 +542,29 @@ tca6507: tca6507@45 {
 		gpio-controller;
 		#gpio-cells = <2>;
 
-		gta04_led0: red_aux@0 {
+		gta04_led0: led@0 {
 			label = "gta04:red:aux";
 			reg = <0x0>;
 		};
 
-		gta04_led1: green_aux@1 {
+		gta04_led1: led@1 {
 			label = "gta04:green:aux";
 			reg = <0x1>;
 		};
 
-		gta04_led3: red_power@3 {
+		gta04_led3: led@3 {
 			label = "gta04:red:power";
 			reg = <0x3>;
 			linux,default-trigger = "default-on";
 		};
 
-		gta04_led4: green_power@4 {
+		gta04_led4: led@4 {
 			label = "gta04:green:power";
 			reg = <0x4>;
 		};
 
-		wifi_reset: wifi_reset@6 { /* reference as <&tca_gpios 0 0> since it is currently the only GPIO */
+		wifi_reset: led@6 {
+			/* reference as <&tca_gpios 0 0> since it is currently the only GPIO */
 			reg = <0x6>;
 			compatible = "gpio";
 		};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes
  2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
                   ` (4 preceding siblings ...)
  2021-10-01  7:34 ` [PATCH 5/5] arm: dts: omap3-gta04: cleanup led node names Andreas Kemnade
@ 2021-10-06  7:46 ` Tony Lindgren
  5 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2021-10-06  7:46 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: bcousson, robh+dt, hns, linux-omap, devicetree, linux-kernel,
	letux-kernel

* Andreas Kemnade <andreas@kemnade.info> [211001 10:35]:
> This series fixes some errors found by make dtbs_check. Most
> do not fix functional issues, just syntax but one typo was
> unveiled by make dtbs_check which only caused no problems by
> luck.

Thanks applying all into omap-for-v5.16/dt.

Tony

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-06  7:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01  7:34 [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Andreas Kemnade
2021-10-01  7:34 ` [PATCH 1/5] arm: dts: omap3-gta04: cleanup LCD definition Andreas Kemnade
2021-10-01  7:34 ` [PATCH 2/5] arm: dts: omap3-gta04: fix missing sensor supply Andreas Kemnade
2021-10-01  7:34 ` [PATCH 3/5] arm: dts: omap3-gta04a5: " Andreas Kemnade
2021-10-01  7:34 ` [PATCH 4/5] arm: dts: omap3-gta04a4: accelerometer irq fix Andreas Kemnade
2021-10-01  7:34 ` [PATCH 5/5] arm: dts: omap3-gta04: cleanup led node names Andreas Kemnade
2021-10-06  7:46 ` [PATCH 0/5] arm: dts: omap3-gta04: dtbs_check fixes Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).