From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
"Jose M. Guisado Gomez" <guigom@riseup.net>,
"David S. Miller" <davem@davemloft.net>,
Arnd Bergmann <arnd@arndb.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 net-next 1/1] net: Mark possible unused variables on stack with __maybe_unused
Date: Fri, 1 Oct 2021 17:50:56 +0300 [thread overview]
Message-ID: <20211001145056.12184-1-andriy.shevchenko@linux.intel.com> (raw)
When compile with COMPILE_TEST=y the -Werror is implied.
If we run `make W=1` the first level warnings will become
the build errors. Some of them related to possible unused
variables. Hence, to allow clean build in such case, mark
them with __maybe_unused.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
net/ipv4/netfilter/nf_reject_ipv4.c | 2 +-
net/ipv6/ip6_fib.c | 3 ++-
net/ipv6/netfilter/nf_reject_ipv6.c | 2 +-
net/socket.c | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c
index 4eed5afca392..52d943426705 100644
--- a/net/ipv4/netfilter/nf_reject_ipv4.c
+++ b/net/ipv4/netfilter/nf_reject_ipv4.c
@@ -239,7 +239,7 @@ void nf_send_reset(struct net *net, struct sock *sk, struct sk_buff *oldskb,
{
struct net_device *br_indev __maybe_unused;
struct sk_buff *nskb;
- struct iphdr *niph;
+ struct iphdr __maybe_unused *niph;
const struct tcphdr *oth;
struct tcphdr _oth;
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 0371d2c14145..8783e49a5465 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1374,7 +1374,8 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
struct nl_info *info, struct netlink_ext_ack *extack)
{
struct fib6_table *table = rt->fib6_table;
- struct fib6_node *fn, *pn = NULL;
+ struct fib6_node *fn;
+ struct fib6_node __maybe_unused *pn = NULL;
int err = -ENOMEM;
int allow_create = 1;
int replace_required = 0;
diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c
index dffeaaaadcde..69b98a6183b3 100644
--- a/net/ipv6/netfilter/nf_reject_ipv6.c
+++ b/net/ipv6/netfilter/nf_reject_ipv6.c
@@ -284,7 +284,7 @@ void nf_send_reset6(struct net *net, struct sock *sk, struct sk_buff *oldskb,
const struct tcphdr *otcph;
unsigned int otcplen, hh_len;
const struct ipv6hdr *oip6h = ipv6_hdr(oldskb);
- struct ipv6hdr *ip6h;
+ struct ipv6hdr __maybe_unused *ip6h;
struct dst_entry *dst = NULL;
struct flowi6 fl6;
diff --git a/net/socket.c b/net/socket.c
index 7f64a6eccf63..fbb442adf27f 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2199,7 +2199,7 @@ int __sys_getsockopt(int fd, int level, int optname, char __user *optval,
{
int err, fput_needed;
struct socket *sock;
- int max_optlen;
+ int __maybe_unused max_optlen;
sock = sockfd_lookup_light(fd, &err, &fput_needed);
if (!sock)
--
2.33.0
next reply other threads:[~2021-10-01 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 14:50 Andy Shevchenko [this message]
2021-10-05 1:24 ` [PATCH v1 net-next 1/1] net: Mark possible unused variables on stack with __maybe_unused Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001145056.12184-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=guigom@riseup.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).