From: kernel test robot <lkp@intel.com>
To: Waiman Long <longman@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <guro@fb.com>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH 1/3] mm, memcg: Don't put offlined memcg into local stock
Date: Sat, 2 Oct 2021 05:17:11 +0800 [thread overview]
Message-ID: <202110020539.WzMpQzEq-lkp@intel.com> (raw)
In-Reply-To: <20211001190938.14050-2-longman@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3336 bytes --]
Hi Waiman,
I love your patch! Yet something to improve:
[auto build test ERROR on hnaz-mm/master]
url: https://github.com/0day-ci/linux/commits/Waiman-Long/mm-memcg-Miscellaneous-cleanups/20211002-031125
base: https://github.com/hnaz/linux-mm master
config: nios2-randconfig-r024-20211001 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/321484dcb4f16ca7bd626adf390222913d188ecc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Waiman-Long/mm-memcg-Miscellaneous-cleanups/20211002-031125
git checkout 321484dcb4f16ca7bd626adf390222913d188ecc
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/asm-generic/percpu.h:5,
from ./arch/nios2/include/generated/asm/percpu.h:1,
from include/linux/irqflags.h:17,
from include/asm-generic/cmpxchg.h:15,
from ./arch/nios2/include/generated/asm/cmpxchg.h:1,
from include/asm-generic/atomic.h:12,
from ./arch/nios2/include/generated/asm/atomic.h:1,
from include/linux/atomic.h:7,
from include/linux/page_counter.h:5,
from mm/memcontrol.c:28:
mm/memcontrol.c: In function 'refill_stock':
>> mm/memcontrol.c:2225:27: error: 'struct mem_cgroup' has no member named 'kmem_state'
2225 | if (unlikely(memcg->kmem_state != KMEM_ONLINE)) {
| ^~
include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
vim +2225 mm/memcontrol.c
2212
2213 /*
2214 * Cache charges(val) to local per_cpu area.
2215 * This will be consumed by consume_stock() function, later.
2216 */
2217 static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages)
2218 {
2219 struct memcg_stock_pcp *stock;
2220 unsigned long flags;
2221
2222 /*
2223 * An offlined memcg shouldn't be put into stock.
2224 */
> 2225 if (unlikely(memcg->kmem_state != KMEM_ONLINE)) {
2226 cancel_charge(memcg, nr_pages);
2227 return;
2228 }
2229
2230 local_irq_save(flags);
2231
2232 stock = this_cpu_ptr(&memcg_stock);
2233 if (stock->cached != memcg) { /* reset if necessary */
2234 drain_stock(stock);
2235 css_get(&memcg->css);
2236 stock->cached = memcg;
2237 }
2238 stock->nr_pages += nr_pages;
2239
2240 if (stock->nr_pages > MEMCG_CHARGE_BATCH)
2241 drain_stock(stock);
2242
2243 local_irq_restore(flags);
2244 }
2245
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30314 bytes --]
next prev parent reply other threads:[~2021-10-01 21:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 19:09 [PATCH 0/3] mm, memcg: Miscellaneous cleanups Waiman Long
2021-10-01 19:09 ` [PATCH 1/3] mm, memcg: Don't put offlined memcg into local stock Waiman Long
2021-10-01 21:17 ` kernel test robot [this message]
2021-10-01 23:06 ` kernel test robot
2021-10-01 23:51 ` Roman Gushchin
2021-10-02 1:54 ` Waiman Long
2022-01-31 3:55 ` Waiman Long
2022-01-31 17:01 ` Roman Gushchin
2022-01-31 17:09 ` Waiman Long
2022-01-31 17:15 ` Waiman Long
2022-01-31 17:19 ` Roman Gushchin
2022-01-31 17:25 ` Waiman Long
2022-01-31 18:00 ` Shakeel Butt
2022-01-31 17:15 ` Roman Gushchin
2021-10-01 19:09 ` [PATCH 2/3] mm, memcg: Remove obsolete memcg_free_kmem() Waiman Long
2021-10-02 0:01 ` Roman Gushchin
2021-10-02 2:03 ` Waiman Long
2021-10-01 19:09 ` [PATCH 3/3] mm, memcg: Ensure valid memcg from objcg within a RCU critical section Waiman Long
2021-10-01 20:24 ` Shakeel Butt
2021-10-01 20:34 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110020539.WzMpQzEq-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).