From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D561C433EF for ; Mon, 4 Oct 2021 09:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A55261215 for ; Mon, 4 Oct 2021 09:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231853AbhJDJNw (ORCPT ); Mon, 4 Oct 2021 05:13:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231851AbhJDJNt (ORCPT ); Mon, 4 Oct 2021 05:13:49 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61554C061749 for ; Mon, 4 Oct 2021 02:12:00 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id v11so3314330pgb.8 for ; Mon, 04 Oct 2021 02:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p/zt6Ihrdo7Rv/qMfG//6nHW1vz4Z3xHHD5M5I4jbOQ=; b=oEtv2Uyiaed2bmjIbuF/vB0QG9ocT4iPqv/zNYk4oCpeZ3YHAbxSLDzHY++HcFaeBW UmfNPQHY0UjD4ITXwNi3bpvEPUmYZANyXj8kPQ+yd9YpDZh/EuZJUYXqrJXbMXIgqOHs MOJwMYfTXWFXJFNMIvr0ESA5Rgotq1aXgXjBbgqndwCbKQdFUtx7/X+2FB67HXqo4EUM D0fejXbVrkt/jYQXA55NgdwmIRTOYC7jUSKdWhSNcqkUjvK4R8DENenI50eKlclRv3jJ zXCfmfV9tYeO303doLc9HPBs6G9mR7PD5vkndfNd5uijzfIEbNOfEC5aAEDG3D3j3LiK Gg1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=p/zt6Ihrdo7Rv/qMfG//6nHW1vz4Z3xHHD5M5I4jbOQ=; b=DdfF+mr/y3aUtSoXpeZvsEoBQ6acgr5RmGGU0eBSwPAn0hUQwZlB8cRV4kQICjDPcw yhMmXLa0uIChNp3G0knea01bW/oIFy71VbPIYCIieEe29SDWb6G53xXI2WW15a4JdqyX 61URMkquV0bqCaFFw0S8BEgVssLuNotQHgzIzi3v/ckQxLmpu41GJZfALO0XgNkw3TCe YDHOSaetXhHvpDISW5WHzQLuG5rgOLUryKp6kV05HqNGFuE6jJk7Jo6x5XQFuoo9mU6o JjfjOajgN9AiEzzEL9nqjJSmIN12uPyt5pIZZ6VoyL34NhNdLcw/i/Vq+8noYJGt541E NmVg== X-Gm-Message-State: AOAM531ubvfMLpO2XwcRCLlPnTuFXhfqfuctTPV26IspgkA9TB7yajg1 4Hl49iFQAUmfvDChqelGTnJC7w== X-Google-Smtp-Source: ABdhPJy0W8ugEcJOIW4QoiueG/Yc3HmOK62CHjUdLDNNiCUoCf91AnhaDt2fgr98vS9LG2/AQVVStQ== X-Received: by 2002:a62:1610:0:b0:447:53fa:a27 with SMTP id 16-20020a621610000000b0044753fa0a27mr24163749pfw.39.1633338719957; Mon, 04 Oct 2021 02:11:59 -0700 (PDT) Received: from localhost ([122.171.247.18]) by smtp.gmail.com with ESMTPSA id o2sm14351598pja.7.2021.10.04.02.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 02:11:59 -0700 (PDT) Date: Mon, 4 Oct 2021 14:41:57 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Lee Jones , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nishanth Menon , Adrian Hunter , Michael Turquette , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Mark Brown , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Mauro Carvalho Chehab , David Heidelberg Subject: Re: [PATCH v13 01/35] opp: Change type of dev_pm_opp_attach_genpd(names) argument Message-ID: <20211004091157.uidbtrhpsl264xjs@vireshk-i7> References: <20210926224058.1252-1-digetx@gmail.com> <20210926224058.1252-2-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210926224058.1252-2-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-09-21, 01:40, Dmitry Osipenko wrote: > Elements of the 'names' array are not changed by the code, constify them > for consistency. > > Signed-off-by: Dmitry Osipenko > --- > drivers/opp/core.c | 6 +++--- > include/linux/pm_opp.h | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 04b4691a8aac..3057beabd370 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2348,12 +2348,12 @@ static void _opp_detach_genpd(struct opp_table *opp_table) > * "required-opps" are added in DT. > */ > struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, > - const char **names, struct device ***virt_devs) > + const char * const *names, struct device ***virt_devs) > { > struct opp_table *opp_table; > struct device *virt_dev; > int index = 0, ret = -EINVAL; > - const char **name = names; > + const char * const *name = names; > > opp_table = _add_opp_table(dev, false); > if (IS_ERR(opp_table)) > @@ -2457,7 +2457,7 @@ static void devm_pm_opp_detach_genpd(void *data) > * > * Return: 0 on success and errorno otherwise. > */ > -int devm_pm_opp_attach_genpd(struct device *dev, const char **names, > +int devm_pm_opp_attach_genpd(struct device *dev, const char * const *names, > struct device ***virt_devs) > { > struct opp_table *opp_table; > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index a95d6fdd20b6..879c138c7b8e 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -156,9 +156,9 @@ int devm_pm_opp_set_clkname(struct device *dev, const char *name); > struct opp_table *dev_pm_opp_register_set_opp_helper(struct device *dev, int (*set_opp)(struct dev_pm_set_opp_data *data)); > void dev_pm_opp_unregister_set_opp_helper(struct opp_table *opp_table); > int devm_pm_opp_register_set_opp_helper(struct device *dev, int (*set_opp)(struct dev_pm_set_opp_data *data)); > -struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names, struct device ***virt_devs); > +struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char * const *names, struct device ***virt_devs); > void dev_pm_opp_detach_genpd(struct opp_table *opp_table); > -int devm_pm_opp_attach_genpd(struct device *dev, const char **names, struct device ***virt_devs); > +int devm_pm_opp_attach_genpd(struct device *dev, const char * const *names, struct device ***virt_devs); > struct dev_pm_opp *dev_pm_opp_xlate_required_opp(struct opp_table *src_table, struct opp_table *dst_table, struct dev_pm_opp *src_opp); > int dev_pm_opp_xlate_performance_state(struct opp_table *src_table, struct opp_table *dst_table, unsigned int pstate); > int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq); > @@ -376,7 +376,7 @@ static inline int devm_pm_opp_set_clkname(struct device *dev, const char *name) > return -EOPNOTSUPP; > } > > -static inline struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char **names, struct device ***virt_devs) > +static inline struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, const char * const *names, struct device ***virt_devs) > { > return ERR_PTR(-EOPNOTSUPP); > } > @@ -384,7 +384,7 @@ static inline struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, cons > static inline void dev_pm_opp_detach_genpd(struct opp_table *opp_table) {} > > static inline int devm_pm_opp_attach_genpd(struct device *dev, > - const char **names, > + const char * const *names, > struct device ***virt_devs) > { > return -EOPNOTSUPP; Applied. Thanks. -- viresh